Tcl Source Code: View Ticket

Ticket UUID:	b322938e081769744eab33ba256e396e24a2f900
Title:	Revised TCL_ZIP_FILE build is less robust
Type:	Bug	Version:	32a303e3d620149f
Submitter:	dgp	Created on:	2019-02-13 19:59:19
Subsystem:	53. Configuration and Build Tools	Assigned To:	dgp
Priority:	5 Medium	Severity:	Important
Status:	Closed	Last Modified:	2019-02-14 19:35:23
Resolution:	Fixed	Closed By:	dgp
		Closed on:	2019-02-14 19:35:23
Description:	Checkin https://core.tcl-lang.org/tcl/info/32a303e3d620149f started some changes to the way the TCL_ZIP_FILE is built. Unfortunately the changes lead to failing tests in a common scenario. If your workspace happens to include an empty directory tcl/library/http1.0 (which many do, because of development history), the old system for building the TCL_ZIP_FILE would not include it, but the new system does include it, or so I surmise. The consequence is that several tests (zipfs-0.[345678]) fail in zipfs.test. I'm open to several points of view whether it is the tests themselves or the new builder of TCL_ZIP_FILE that is broken, but this should be resolved.
User Comments:	dgp added on 2019-02-14 19:35:23: Thanks for the fix. I made a minor change in the pathname construction that might help portability, and if not should at least be harmless. sebres added on 2019-02-14 11:04:03: (text/x-fossil-wiki) I got it well reproduced (with non-empty http1.0 by interim switch from 8.6, no idea why it has not been removed by fossil). Fixed in [/vdiff?from=ab484359285cb7c1&to=6c4886e1e14f67e4\|[6c4886e1e1]] now and can be closed IMO. <i>(related commits [59607dfd9e]..[6c4886e1e1])</i> sebres added on 2019-02-13 23:52:24: Hmm... The amend is mine. Just strange I cannot reproduce it. What is the ZIP in your case (installed or minizip)? BTW I thought packing of empty dir in zip is impossible. I can extend it with check for empty dir (or possibly some zip-switch to ignore that). Could you provide an exact error message of test too?