Tcl Source Code

Ticket Change Details
Login
Overview

Artifact ID: d36648d49401f45a3472cb313bf9c4c0eba50a3e
Ticket: adb198c256df8c4192838cc3c1112fb2821314e9
Potential Tcl_Obj leak in tclPathObj.c
User & Date: dgp 2017-07-06 14:14:56
Changes

  1. closedate changed to: "2457941.09370936"
  2. icomment:
    
    This large conditional block
    
    https://core.tcl.tk/tcl/artifact/6c6428a1c565405c?ln=877-960
    
    is conditioned on (i == 0) among others.
    
    That means we can only execute this block on
    the first iteration of the for loop, and at
    that point, nothing has had the chance to make
    res contain anything other than NULL.  Much
    code directing what to do when (res != NULL)
    is actually useless.  Some asserts would be better,
    I think.
    
  3. login: "dgp"
  4. mimetype: "text/plain"