Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
Overview
| Comment: | Changed position of flag evaluation as proposed by Phil Hoffman |
|---|---|
| Downloads: | Tarball | ZIP archive | SQL archive |
| Timelines: | family | ancestors | descendants | both | bug-2413550 |
| Files: | files | file ages | folders |
| SHA1: |
024a5233616e9704f5b94582deba61b5 |
| User & Date: | oehhar 2014-02-11 08:53:33 |
References
|
2014-02-14
| ||
| 07:59 | • Ticket [2413550fff] Avoid double-open of serial ports on Windows status still Open with 4 other changes artifact: 5776ddc74a user: oehhar | |
Context
|
2014-02-24
| ||
| 17:25 | Do not reopen a win serial channel for serial detection. There are issues with some Bluetooth virtua... check-in: b6459ef66c user: oehhar tags: core-8-5-branch | |
|
2014-02-11
| ||
| 08:53 | Changed position of flag evaluation as proposed by Phil Hoffman Closed-Leaf check-in: 024a523361 user: oehhar tags: bug-2413550 | |
|
2014-01-30
| ||
| 15:02 | merge 8.5 check-in: 5ef480c185 user: oehhar tags: bug-2413550 | |
Changes
Changes to win/tclWinChan.c.
| ︙ | ︙ | |||
881 882 883 884 885 886 887 |
createMode = TRUNCATE_EXISTING;
break;
default:
createMode = OPEN_EXISTING;
break;
}
| < < < < < < < < < < < < < < < < < < | 881 882 883 884 885 886 887 888 889 890 891 892 893 894 |
createMode = TRUNCATE_EXISTING;
break;
default:
createMode = OPEN_EXISTING;
break;
}
/*
* [2413550] Avoid double-open of serial ports on Windows
* Special handling for Windows serial ports by a "name-hint"
* to directly open it with the OVERLAPPED flag set.
*/
if( NativeIsComPort(nativeName) ) {
|
| ︙ | ︙ | |||
926 927 928 929 930 931 932 933 934 935 936 937 938 939 |
* For natively named Windows serial ports we are done.
*/
channel = TclWinOpenSerialChannel(handle, channelName,
channelPermissions);
return channel;
}
/*
* Set up the file sharing mode. We want to allow simultaneous access.
*/
shareMode = FILE_SHARE_READ | FILE_SHARE_WRITE;
/*
| > > > > > > > > > > > > > > > > > > | 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 |
* For natively named Windows serial ports we are done.
*/
channel = TclWinOpenSerialChannel(handle, channelName,
channelPermissions);
return channel;
}
/*
* If the file is being created, get the file attributes from the
* permissions argument, else use the existing file attributes.
*/
if (mode & O_CREAT) {
if (permissions & S_IWRITE) {
flags = FILE_ATTRIBUTE_NORMAL;
} else {
flags = FILE_ATTRIBUTE_READONLY;
}
} else {
flags = (*tclWinProcs->getFileAttributesProc)(nativeName);
if (flags == 0xFFFFFFFF) {
flags = 0;
}
}
/*
* Set up the file sharing mode. We want to allow simultaneous access.
*/
shareMode = FILE_SHARE_READ | FILE_SHARE_WRITE;
/*
|
| ︙ | ︙ |