Attachment "506653.patch" to
ticket [506653ffff]
added by
dgp
2004-07-02 04:26:33.
Index: generic/tclEncoding.c
===================================================================
RCS file: /cvsroot/tcl/tcl/generic/tclEncoding.c,v
retrieving revision 1.23
diff -u -r1.23 tclEncoding.c
--- generic/tclEncoding.c 18 Jun 2004 20:38:01 -0000 1.23
+++ generic/tclEncoding.c 1 Jul 2004 21:24:06 -0000
@@ -1266,6 +1266,9 @@
}
if ((encoding == NULL) && (interp != NULL)) {
Tcl_AppendResult(interp, "invalid encoding file \"", name, "\"", NULL);
+ if (ch == 'E') {
+ Tcl_AppendResult(interp, " or missing sub-encoding", NULL);
+ }
}
Tcl_Close(NULL, chan);
return encoding;
@@ -1633,7 +1636,7 @@
CONST char *name; /* Name for new encoding. */
Tcl_Channel chan; /* File containing new encoding. */
{
- int i;
+ int i, missingSubEncoding = 0;
unsigned int size;
Tcl_DString escapeData;
char init[16], final[16];
@@ -1677,16 +1680,27 @@
strncpy(est.name, argv[0], sizeof(est.name));
est.name[sizeof(est.name) - 1] = '\0';
- /* To avoid infinite recursion in [encoding system iso2022-*]*/
- Tcl_GetEncoding(NULL, est.name);
+ /*
+ * Load the subencodings first so we're never stuck
+ * trying to use a half-loaded system encoding to
+ * open/read a *.enc file.
+ */
- est.encodingPtr = NULL;
+ est.encodingPtr = (Encoding *) Tcl_GetEncoding(NULL, est.name);
+ if ((est.encodingPtr == NULL)
+ || (est.encodingPtr->toUtfProc != TableToUtfProc)) {
+ missingSubEncoding = 1;
+ }
Tcl_DStringAppend(&escapeData, (char *) &est, sizeof(est));
}
}
ckfree((char *) argv);
Tcl_DStringFree(&lineString);
}
+ if (missingSubEncoding) {
+ Tcl_DStringFree(&escapeData);
+ return NULL;
+ }
size = sizeof(EscapeEncodingData)
- sizeof(EscapeSubTable) + Tcl_DStringLength(&escapeData);
@@ -2897,6 +2911,11 @@
subTablePtr = &dataPtr->subTables[state];
encodingPtr = subTablePtr->encodingPtr;
if (encodingPtr == NULL) {
+ /*
+ * Now that escape encodings load their sub-encodings first, and
+ * fail to load if any sub-encodings are missing, this branch should
+ * never happen.
+ */
encodingPtr = (Encoding *) Tcl_GetEncoding(NULL, subTablePtr->name);
if ((encodingPtr == NULL)
|| (encodingPtr->toUtfProc != TableToUtfProc)) {