Tcl Source Code

Artifact [a4d106c190]
Login

Artifact a4d106c1909c1eb5e8777b19d956abd182673e39:

Attachment "None" to ticket [403174ffff] added by dkf 2001-01-10 22:39:45.
Index: ChangeLog
===================================================================
RCS file: /cvsroot/tcl/tcl/ChangeLog,v
retrieving revision 1.361
diff -u -r1.361 ChangeLog
--- ChangeLog	2001/01/04 21:30:49	1.361
+++ ChangeLog	2001/01/10 15:35:32
@@ -1,3 +1,12 @@
+2001-01-10  Donal K. Fellows  <[email protected]>
+
+	* tests/winPipe.test (winpipe-1.20): 
+	* tests/winDde.test (createChildProcess): 
+	* tests/pkgMkIndex.test (pkgtest::createIndex):  Removed
+	assumption that paths contain no spaces which causes problems with
+	both [eval] and [open |...] due to the well-known differences
+	between lists and strings.  Fixes bug #119406
+
 2001-01-04  Don Porter  <[email protected]>
 	* tests/unixInit.test:
 	* unix/tclUnixInit.c (TclpInitLibraryPath):
Index: tests/pkgMkIndex.test
===================================================================
RCS file: /cvsroot/tcl/tcl/tests/pkgMkIndex.test,v
retrieving revision 1.17
diff -u -r1.17 pkgMkIndex.test
--- tests/pkgMkIndex.test	2000/07/19 21:40:57	1.17
+++ tests/pkgMkIndex.test	2001/01/10 15:35:33
@@ -165,7 +165,7 @@
  
     if {[catch {
 	file delete [file join $dirPath pkgIndex.tcl]
-	eval pkg_mkIndex $options $dirPath $patternList
+	eval pkg_mkIndex $options [list $dirPath] $patternList
     } err]} {
 	return [list 1 $err]
     }
Index: tests/winDde.test
===================================================================
RCS file: /cvsroot/tcl/tcl/tests/winDde.test,v
retrieving revision 1.8
diff -u -r1.8 winDde.test
--- tests/winDde.test	2000/04/10 17:19:06	1.8
+++ tests/winDde.test	2001/01/10 15:35:33
@@ -56,7 +56,7 @@
     }
     close $f
     
-    set f [open "|$tcltest::tcltest $::scriptName" r]
+    set f [open |[list $tcltest::tcltest $::scriptName] r]
     gets $f
     return $f
 }
Index: tests/winPipe.test
===================================================================
RCS file: /cvsroot/tcl/tcl/tests/winPipe.test,v
retrieving revision 1.12
diff -u -r1.12 winPipe.test
--- tests/winPipe.test	2000/04/10 17:19:06	1.12
+++ tests/winPipe.test	2001/01/10 15:35:33
@@ -156,7 +156,7 @@
 } {little stderr32}
 test winpipe-1.20 {32 bit comprehensive tests: write to application} \
 	{pcOnly stdio cat32} {
-    set f [open "|$cat32 > stdout" w]
+    set f [open |[list $cat32 >stdout] w]
     puts -nonewline $f "foo"
     catch {close $f} msg
     list [contents stdout] $msg