Tcl Source Code

Artifact 2e39900e820631df471d1348a1cd59c87e4aa074:

Attachment "perf-tweak-HEAD.diff" to ticket [1064243fff] added by das 2004-11-11 08:11:59.

---

Index: generic/tclHash.c
===================================================================
RCS file: /cvsroot/tcl/tcl/generic/tclHash.c,v
retrieving revision 1.21
diff -u -p -r1.21 tclHash.c
--- generic/tclHash.c	6 Oct 2004 13:43:53 -0000	1.21
+++ generic/tclHash.c	9 Nov 2004 18:55:10 -0000
@@ -310,6 +310,7 @@ Tcl_FindHashEntry(tablePtr, key)
      */
 
     if (typePtr->compareKeysProc) {
+	Tcl_CompareHashKeysProc *compareKeysProc = typePtr->compareKeysProc;
 	for (hPtr = tablePtr->buckets[index]; hPtr != NULL;
 	        hPtr = hPtr->nextPtr) {
 #if TCL_HASH_KEY_STORE_HASH
@@ -317,7 +318,7 @@ Tcl_FindHashEntry(tablePtr, key)
 		continue;
 	    }
 #endif
-	    if (typePtr->compareKeysProc ((VOID *) key, hPtr)) {
+	    if (compareKeysProc ((VOID *) key, hPtr)) {
 		return hPtr;
 	    }
 	}
@@ -408,6 +409,7 @@ Tcl_CreateHashEntry(tablePtr, key, newPt
      */
 
     if (typePtr->compareKeysProc) {
+	Tcl_CompareHashKeysProc *compareKeysProc = typePtr->compareKeysProc;
 	for (hPtr = tablePtr->buckets[index]; hPtr != NULL;
 	        hPtr = hPtr->nextPtr) {
 #if TCL_HASH_KEY_STORE_HASH
@@ -415,7 +417,7 @@ Tcl_CreateHashEntry(tablePtr, key, newPt
 		continue;
 	    }
 #endif
-	    if (typePtr->compareKeysProc ((VOID *) key, hPtr)) {
+	    if (compareKeysProc ((VOID *) key, hPtr)) {
 		*newPtr = 0;
 		return hPtr;
 	    }
@@ -701,13 +703,14 @@ Tcl_NextHashEntry(searchPtr)
 					 * Tcl_FirstHashEntry. */
 {
     Tcl_HashEntry *hPtr;
+    Tcl_HashTable *tablePtr = searchPtr->tablePtr;
 
     while (searchPtr->nextEntryPtr == NULL) {
-	if (searchPtr->nextIndex >= searchPtr->tablePtr->numBuckets) {
+	if (searchPtr->nextIndex >= tablePtr->numBuckets) {
 	    return NULL;
 	}
 	searchPtr->nextEntryPtr =
-		searchPtr->tablePtr->buckets[searchPtr->nextIndex];
+		tablePtr->buckets[searchPtr->nextIndex];
 	searchPtr->nextIndex++;
     }
     hPtr = searchPtr->nextEntryPtr;
Index: generic/tclListObj.c
===================================================================
RCS file: /cvsroot/tcl/tcl/generic/tclListObj.c,v
retrieving revision 1.19
diff -u -p -r1.19 tclListObj.c
--- generic/tclListObj.c	29 Sep 2004 22:17:30 -0000	1.19
+++ generic/tclListObj.c	9 Nov 2004 18:55:10 -0000
@@ -791,17 +791,9 @@ Tcl_ListObjReplace(interp, listPtr, firs
 	if ((numAfterLast > 0) && (shift != 0)) {
 	    Tcl_Obj **src, **dst;
 
-	    if (shift < 0) {
-		for (src = elemPtrs + start, dst = src + shift;
-			numAfterLast > 0; numAfterLast--, src++, dst++) {
-		    *dst = *src;
-		}
-	    } else {
-		for (src = elemPtrs + numElems - 1, dst = src + shift;
-			numAfterLast > 0; numAfterLast--, src--, dst--) {
-		    *dst = *src;
-		}
-	    }
+	    src = elemPtrs + start; dst = src + shift;
+	    memmove((VOID*) dst, (VOID*) src, 
+	            (size_t) (numAfterLast * sizeof(Tcl_Obj*)));
 	}
 
 	/*