Overview
| Artifact ID: | fc00ac785864a5d97f4fa0c9f3d370138a2d2059 |
|---|---|
| Ticket: | 3295abf0786394dc8bb96ecadc30ce4a57e6af0e
ico: incorrect use of $img put |
| User & Date: | anonymous 2017-01-09 17:31:11 |
Changes
- assignee changed to: "nobody"
- closer changed to: "nobody"
- cmimetype changed to: "text/x-fossil-wiki"
- comment changed to:
In the ico module there are the following four lines: <verbatim> /tklib-0.6/modules/ico/ico.tcl(557): $img put -to 0 0 $colors /tklib-0.6/modules/ico/ico.tcl(563): $img put -to $x $y $clr /tklib-0.6/modules/ico/ico0.tcl(400): $img put -to 0 0 $colors /tklib-0.6/modules/ico/ico0.tcl(406): $img put -to $x $y $clr </verbatim> This is an incorrect use of the put command. Documentation says: <b>imageName put data ?option value(s) ...? </b> However the code in the ico module uses: <b>imageName put ?option value(s) ...? data </b> The latter used to be accepted, although undocumented, but will soon no longer be. See: http://core.tcl.tk/tk/tktview?name=d4fb4e80d2 Fix is easy and consists in swapping the order of the data and the options arguments.
- foundin changed to: "trunk"
- is_private changed to: "0"
- login: "anonymous"
- priority changed to: "5 Medium"
- private_contact changed to: "a013af67114eccc19ad12b04f14923acea9e96b7"
- resolution changed to: "None"
- severity changed to: "Minor"
- status changed to: "Open"
- submitter changed to: "anonymous"
- subsystem changed to: "tklib :: ico"
- title changed to: "ico: incorrect use of $img put"
- type changed to: "Bug"