Ticket UUID: | e2f801f6ee3784ebff175a76451a993c4762ad8a | |||
Title: | tkProcessEvent return value is trivial | |||
Type: | Patch | Version: | trunk | |
Submitter: | anonymous | Created on: | 2014-01-23 14:39:39 | |
Subsystem: | 70. Event Loop | Assigned To: | dgp | |
Priority: | 5 Medium | Severity: | Minor | |
Status: | Closed | Last Modified: | 2014-10-31 19:29:35 | |
Resolution: | Postponed | Closed By: | dgp | |
Closed on: | 2014-10-31 19:29:35 | |||
Description: |
The return value of tkProcessEvent in macosx/tkMacOSXEvent.c is processedEvent, which is either the same as the input argument theEvent, or equal to the return value of tkProcessKeyEvent or tkProcessMouseEvent. As these two functions always return the input argument theEvent, the return value of tkProcessEvent is always the same as the input argument theEvent. Therefore, in tkMacOSXNotify.c we do not need to check for the return value of tkProcessEvent. The attached patch is relative to the source code after applying this patch: https://core.tcl.tk/tk/tktview?name=bc4552d0bb | |||
User Comments: |
dgp added on 2014-10-31 19:29:35:
I'll not argue. closed it is. anonymous added on 2014-10-31 00:48:16: I submitted this patch back in January, but since then I have been looking at the Tcl/Tk event loop code in much more detail, and it's clear to me that much more extensive changes are needed to solve the event loop issues. I would suggest to close this ticket for now, and wait for a comprehensive solution of the event loop (which may take a few more months). kevin_walzer added on 2014-10-29 13:55:39: This patch does not improve the performance of the event loop. kevin_walzer added on 2014-02-02 02:39:51: This patch touches a large number of files for what appears to be essentially a cosmetic change. I don't see any side effects, but it's also not clear to me what problem the patch solves. The event loop issue, as outlined in other bugs, remains unsolved. |
Attachments:
- tk.patch [download] added by anonymous on 2014-01-23 14:41:23. [details]