Tk Source Code

View Ticket
Login
Ticket UUID: 3545457
Title: Crash on packing a menubutton with Tk 8.4.19
Type: Bug Version: obsolete: 8.4.19
Submitter: fvogel Created on: 2012-07-18 15:54:47
Subsystem: 12. Unix Menus Assigned To: fvogel
Priority: 8 Severity: Minor
Status: Closed Last Modified: 2014-02-19 21:42:32
Resolution: Fixed Closed By: fvogel
    Closed on: 2013-09-23 21:42:26
Description:
Crash on packing a menubutton with Tk 8.4.19 (core-8-4-branch)

Test case:

menubutton .mb
pack .mb  ;  # crash!


Happens with 8.4 only, not with 8.5 or trunk.

The issue is missing initialization of variables width and height inTkpDisplayMenuButton in file unix/tkUnixMenubu.c

This problem has been fixed on 2007-04-25 19:08 by:
  9c8837c194 * unix/tkUnixMenubu.c (TkpDisplayMenuButton): init width/height to 0
but apparently only in the trunk (of this time, which is now core-8-5-branch).
User Comments: fvogelnew1 added on 2012-07-20 04:38:13:

allow_comments - 1

Thanks for your review.

Fix merged in core-8-4-branch

nijtmans added on 2012-07-19 01:55:33:
Very clear analysis, without any doubt. Please commit.

fvogelnew1 added on 2012-07-19 01:42:07:
Patch proposed in branch bug-3545457 for review.