| Ticket UUID: | 3479498 | |||
| Title: | no limit to -blockcursor width | |||
| Type: | Patch | Version: | None | |
| Submitter: | fvogel | Created on: | 2012-01-25 07:54:00 | |
| Subsystem: | 18. [text] | Assigned To: | fvogel | |
| Priority: | 7 High | Severity: | Minor | |
| Status: | Closed | Last Modified: | 2014-02-19 21:42:31 | |
| Resolution: | Fixed | Closed By: | fvogel | |
| Closed on: | 2013-09-23 21:39:25 | |||
| Description: |
The attached patch fixes items 1754043 and 2321450 (which really are dups): no limit to -blockcursor width: https://sourceforge.net/tracker/?func=detail&aid=1754043&group_id=12997&atid=112997 Text widget block cursor problem: https://sourceforge.net/tracker/?func=detail&aid=2321450&group_id=12997&atid=112997 The patch is against core-8-5-branch. | |||
| User Comments: |
fvogelnew1 added on 2012-01-26 14:26:18:
allow_comments - 1 fvogelnew1 added on 2012-01-26 14:25:24: Merged in core-8-5-branch and trunk. Closing now. fvogelnew1 added on 2012-01-26 05:00:41: The proposed patch is available for review in branch patch-3479498 dkf added on 2012-01-25 20:12:29: If you're uncertain, just commit to a (new feature development) branch. Branching is enormously easy and cheap now we're using fossil. It also means that if we need to evolve the code before feeding back in, we can do so easily. I tend to prefix my feature branch names with my initials, but you can do it any way you want. I suggest not calling it "core..." or "trunk..." or "bug..." :-) fvogelnew1 added on 2012-01-25 17:10:50: Jan, about commit access: Basically I feel quite comfortable in having someone reviewing my patches before they go in the production branches. I'm a bit shy of the new responsibility. However after all this is version control, i.e. commits can always be reverted if people are not okay with them. So, yes, why not? nijtmans added on 2012-01-25 15:57:15: This patch is so trivial, it can go in right away. Noting that the -blockcursor option was introduced in Tk 8.5, so this patch is for core-8-5-branch and trunk only. François, would you be interested in commit access to Tk''s fossil repositlry, so you can commit those kinds of things yourself? fvogelnew1 added on 2012-01-25 14:55:26: Test case: text .t -blockcursor true pack .t .t insert end "Some text here\n" .t insert end "Further text here" Move the insert cursor in the text, and at the end of lines. See it does no longer expand to the right end of the widget. fvogelnew1 added on 2012-01-25 14:54:04: File Added - 433955: 1754043_2321450_V1.patch | |||
Attachments:
- 1754043_2321450_V1.patch [download] added by fvogelnew1 on 2012-01-25 14:54:04. [details]