Tk Source Code

Timeline
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

146 check-ins using file generic/tkConsole.c version e52bb3c5

2014-02-07
08:37
[6867cc13a4] "tk fontchooser configure" overwrites global variables check-in: 9c6d8f0c user: jan.nijtmans tags: trunk
2014-02-06
21:24
Merged. Ticket [3279221]: Fixed setup of popup menu to prevent immediate disappearance due to an event race. check-in: 79c4b253 user: andreask tags: trunk
2014-02-04
21:56
Satisfy required position of __stdcall from VC++ check-in: c8ba96b8 user: jan.nijtmans tags: trunk
21:40
Add missing __stdcall (which crashes on win32) check-in: 49309caa user: jan.nijtmans tags: trunk
08:52
Fix 651e828a52: Wrong Windows version reported for Windows 8.1. Remove some dead code (since Win95/98/ME is no longer supported) check-in: 7f9c6ea1 user: jan.nijtmans tags: trunk
2014-02-03
19:12
merge-mark check-in: 28d2e4c0 user: jan.nijtmans tags: trunk
19:01
Squash problem with native AIX cc not allowing direct macro redefinition. check-in: 7bac115e user: andreask tags: trunk
2014-01-25
21:37
Fix TK_SHLIB_LD_EXTRAS for FreeBSD (and Cygwin), reported by Pietro Cerutti check-in: c650249c user: jan.nijtmans tags: trunk
2014-01-23
22:39
Put -lfontconfig in XFT_LIBS, not XLIBSW flag check-in: ef49212b user: jan.nijtmans tags: trunk
22:27
Fix [3606644]: Static build misses fontconfig check-in: 320dbce6 user: jan.nijtmans tags: trunk
2014-01-02
17:48
Arjen Marcus' patch, with minor edits in the ParseProc and PrintProc (making the offset obsolete). TODO: -other items than ovals and rects, -documentation Leaf check-in: b2e1fe4d user: jan.nijtmans tags: rfe-e9a842a3c5
2013-11-20
15:39
Some bit of Windows 8.1 compatibility: See http://msdn.microsoft.com/en-us/library/windows/desktop/dn302074.aspx check-in: 60b06a2e user: jan.nijtmans tags: trunk
09:56
typo check-in: e4eb7f30 user: jan.nijtmans tags: trunk
09:11
Store menu option tables in Thread storage in stead of allocated storage. This makes "menu" a normal command without needing special initialization tricks. check-in: 8822345d user: jan.nijtmans tags: trunk
2013-11-19
11:53
Revert [3eaa6c984a] (Enh 2959069), as it turns out that -fvisibility=hidden only affects definitions and not declarations. Therefore explicitely declaring each MODULE_SCOPE function as __attribute__((__visibility__("hidden")) is much better. Suggested by Stuart Cassoff (Thanks!). check-in: ac37b026 user: jan.nijtmans tags: trunk
2013-11-18
15:37
Cygwin: In stead of checking whether the win32 part is configured properly, just configure it when needed. Always build the stub library first (and - on Cygwin - configure win32 properly just before building the stub library) check-in: 3a0f36ea user: jan.nijtmans tags: trunk
2013-11-12
13:24
Fix "creative writing" problem. check-in: cb8d21bd user: dgp tags: trunk
2013-11-11
10:56
Fix uninitialized variable in 16-bit PPM handling. [1632447] follow-up. check-in: 8a4cf9fe user: jan.nijtmans tags: trunk
10:18
Fix [0aa5e852dc]: Accept newline characters as value in Tk option files check-in: b01dc9d0 user: jan.nijtmans tags: trunk
08:41
Fix bug [f214b8ad5b]: shutdown woes check-in: 9fc8df19 user: jan.nijtmans tags: trunk
2013-11-08
09:16
Since fontCache is the first field of struct TkFontInfo, make the code somewhat better readable. But actually it's no change at all. This is my only review comment! Good work! Closed-Leaf check-in: fbbdd0a3 user: jan.nijtmans tags: bug-f214b8
2013-11-05
21:06
New test font-47.1 demonstrates effectiveness of the fix. check-in: 9b99ee4b user: dgp tags: bug-f214b8
20:58
First draft patch trying to fix [f214b8ad5b]. check-in: 6f1d75a1 user: dgp tags: bug-f214b8
12:47
Fix 426679ef7d: Having man.macros after .TH breaks rendering on OpenBSD and possibly others. check-in: 8b40f8ca user: jan.nijtmans tags: trunk
2013-11-03
19:56
Improved tests to cover StringReadPPM properly. check-in: b172326d user: dkf tags: trunk
16:49
Fix StringReadPPM function from previous commit check-in: fb1fb2fd user: jan.nijtmans tags: trunk
11:33
[1632447]: Allow the PPM maxval to go up to 65535, to conform with a format definition change from around 2000 (even if that's a rare format). check-in: 251c1226 user: dkf tags: trunk
2013-10-31
22:01
merge trunk Closed-Leaf check-in: 2e7dccd2 user: jan.nijtmans tags: bug-f214b8ad5b
21:25
Fix refcount bug in FreeFontObjProc. Could result in freeing a TkFont which was already freed. check-in: 61cefa0e user: jan.nijtmans tags: trunk
11:27
Suggested fix for [3604346]: Checkin [a7eee0499a] broke Ttk docs. Closed-Leaf check-in: 7de29bd8 user: jan.nijtmans tags: bug-3604346
09:35
Fix [c0cc9fd153]: PNG parser does not support uppercase format string (using -format) check-in: 8363f1b5 user: jan.nijtmans tags: trunk
09:27
Put extern "C" guards around all stub table struct definitions, so it is usable to be used for C++ compilers as well without the danger of modifying the calling convention. For tkDecls.h, ttkDecls.h tkIntXlibDecls.h is was no problem, because tk.h, tkTheme.h and Xlib.h already contain those guards. But not for the other *Decls.h files. check-in: 83a9d727 user: jan.nijtmans tags: trunk
2013-10-29
13:59
Make "menu" a normal command, initialized like any other Tk command. check-in: 1abdce95 user: jan.nijtmans tags: bug-f214b8ad5b
2013-10-28
16:26
Some refactoring as initial attempt to fix [f214b8ad5b]. Not finished/tested yet. check-in: ce328736 user: jan.nijtmans tags: bug-f214b8ad5b
09:54
Fix [3603436fff]: png save has wrong component indexes check-in: a0a8d6bc user: jan.nijtmans tags: trunk
2013-10-27
20:29
Fix for drawing lags on OS X Mavericks; thanks to Ned Deily for report and Daniel Steffen for patch check-in: e7f7a909 user: kevin_walzer tags: trunk
2013-10-04
11:27
When compiling with MSVC++, no longer link the stub library with msvcrt??.dll. This way, workarounds in extensions like http://core.tcl.tk/itcl/info/a961f0729c are no longer necessary. check-in: a8a2cbf0 user: jan.nijtmans tags: trunk
2013-10-02
08:27
Fix compilation with latest MinGW-w64 version 3.0: Conflict on EXCEPTION_REGISTRATION typedef, which means something completely different in MinGW-w64. check-in: 3dd49eb9 user: jan.nijtmans tags: trunk
2013-10-01
07:44
merge-mark check-in: 46bc881f user: jan.nijtmans tags: trunk
07:36
Disable command line globbing on MinGW compiles, just as MSVC and MinGW-w64 don't enable command line globbing either by default. check-in: 8ad56ea4 user: jan.nijtmans tags: trunk
2013-09-27
09:42
Workaround for MinGW bug #2065. Both MinGW and MinGW-w64 (32-bit) are affected. Even though Win64 is not affected, adding -static-libgcc doesn't harm there, and we don't want to distrubute additional dll's with MinGW-compiled Tcl anyway. check-in: 132bf978 user: jan.nijtmans tags: trunk
2013-09-24
05:44
Fix one missed makefile comment change. Closed-Leaf check-in: 77068f8e user: mistachkin tags: win32-arm
05:24
Support compiling Tk for Win32 on ARM. check-in: 19c258d4 user: mistachkin tags: win32-arm
2013-09-23
19:51
Documentation tweaks to make index entries more informative. check-in: a469d90b user: dkf tags: trunk
12:54
workaround for mingw bug http://comments.gmane.org/gmane.comp.gnu.mingw.user/41724 check-in: 8ddb5cac user: jan.nijtmans tags: trunk
2013-09-20
05:32
merge release check-in: bde04c88 user: dgp tags: trunk
2013-09-16
19:10
merge trunk; update changes Closed-Leaf check-in: 51b9512d user: dgp tags: core-8-6-1, core-8-6-1-rc
13:53
merge-mark check-in: 24fd88fe user: jan.nijtmans tags: trunk
2013-09-07
08:49
Enable XInitThreads on some platforms where it might be safe. Leaf check-in: 86731397 user: jan.nijtmans tags: bug-3613668
2013-09-03
17:39
make dist check-in: ef914046 user: dgp tags: core-8-6-1-rc
16:48
Update changes check-in: 66ba9632 user: dgp tags: core-8-6-1-rc
2013-08-30
22:09
Bump to 8.6.1. check-in: 446c66c4 user: dgp tags: core-8-6-1-rc
2013-08-26
11:02
Changelog entries for previous two commits check-in: d0e51638 user: jan.nijtmans tags: trunk
2013-08-25
03:04
Fix for 3016181, thanks to Tom Goddard for patch check-in: 1f184c73 user: kevin_walzer tags: trunk
2013-08-15
03:56
Bug [c597acdab3]: Call [$pb step] in tail position in ttk::progressbar::Autoincrement, so that the widget is in a consistent state when any write traces on the linked -variable are fired. check-in: 8ea3ccb4 user: jenglish tags: trunk
2013-08-14
13:16
Bug [069c9e43c4]: FreeOptionInternalRep() breaks Tk_CreateOptionTable() check-in: aaf11bdc user: jan.nijtmans tags: trunk
10:53
Fix reference counting for "option" objects, when being duplicated. Closed-Leaf check-in: bc21cf92 user: jan.nijtmans tags: bug-069c9e43c4
2013-08-11
14:55
rebase check-in: aa61bf42 user: jan.nijtmans tags: bug-069c9e43c4
14:51
Sync with Tcl version of tcl.m4 check-in: f2303527 user: jan.nijtmans tags: trunk
2013-08-01
09:18
Fix some comments check-in: 9aa08cb3 user: jan.nijtmans tags: bug-069c9e43c4
08:51
rebase check-in: 218ef501 user: jan.nijtmans tags: bug-069c9e43c4
08:47
Make sure that in test-cases, Tk_DeleteOptionTable() is never called more times than the corresponding Tk_CreateOptionTable(). Although it doesn't crash now, this behavior cannot be depended on. check-in: 5b0cea38 user: jan.nijtmans tags: trunk
2013-07-31
11:47
Suggested fix for Bug [069c9e43c4] check-in: 7ece6c71 user: jan.nijtmans tags: bug-069c9e43c4
2013-07-26
14:23
Don't hardcode "tclWinError.o" for Cygwin. check-in: ef0cac7c user: jan.nijtmans tags: trunk
09:25
sync with Tcl version check-in: 81d1637c user: jan.nijtmans tags: trunk
2013-07-12
10:18
On Cygwin, don't duplicate TkPutImage definition in tkUnixPort.h, in stead bring it in though tkIntXlibDecls.h check-in: b96b92ac user: jan.nijtmans tags: trunk
2013-07-07
09:26
Use X11/Xlib.h for checking where X11 can be found in stead of X11/XIntrinsic.h. Suggested by Pietro Cerutti. (backported from tclconfig) check-in: e8359b0f user: jan.nijtmans tags: trunk
00:43
OpenBSD/m88k is now elf. Remove unneeded elf check. check-in: 4c584d69 user: stwo tags: trunk
2013-07-02
07:26
Bug 32afa6e256: dirent64 check is incorrect in tcl.m4. Thanks to Brian Griffin. check-in: f3fee9f1 user: jan.nijtmans tags: trunk
2013-06-28
13:16
merge-mark check-in: 5606b8b7 user: jan.nijtmans tags: trunk
11:22
Bug [2501278]: ttk::scale keyboard binding problem check-in: 57f9af77 user: jan.nijtmans tags: trunk
2013-06-27
19:02
manually revert changes caused by different autoconf versions check-in: fea7f4b3 user: jan.nijtmans tags: trunk
18:47
fix installation on MacOSX check-in: de7a75fc user: jan.nijtmans tags: trunk
2013-06-17
17:25
Updates to redirect bug reports to the new tracker location check-in: be61bb59 user: dgp tags: trunk
2013-06-14
10:36
Static Cygwin wish.exe cannot link with win32's static libtk86.a (because it expects a different runtime), so configure shouldn't even try to do this. (On a dynamic wish.exe this works, this is exactly how wish can run even without X11). Don't use deprecated stricmp/strnicmp any more, but underscored variant for non-GNU compilers. check-in: a31e03f9 user: jan.nijtmans tags: trunk
2013-06-13
11:02
Additional install of libtk86.a for Cygwin Remove unused @EXTRA_AQUA_OBJS and @EXTRA_AQUA_SRCS check-in: 1bfeda09 user: jan.nijtmans tags: trunk
10:37
Some more fixes for Cygwin32/64 in win32 GUI mode. Now that this is fully working, eliminate all usage of WISH_BUILD_LIB_SPEC: TK_BUILD_LIB_SPEC can be used everywhere in stead. Remove some old carbon-leftovers from configure/make (see [3607215]). check-in: 456e5dfc user: jan.nijtmans tags: trunk
2013-06-11
10:12
Changelog: more bug-fixes which are fixed by the same commit. check-in: f42684ba user: jan.nijtmans tags: trunk
2013-06-07
09:45
some code cleanup, remove structure which is no longer used. check-in: aa0b268a user: jan.nijtmans tags: trunk
08:51
merge-mark check-in: 0ff86ad6 user: jan.nijtmans tags: trunk
2013-06-06
10:00
Add support for X11 GUI-mode on Cygwin64 check-in: 27791af0 user: jan.nijtmans tags: trunk
2013-06-05
13:03
Fix [2100430]: ttk::entry widget index must be integer check-in: cf843515 user: jan.nijtmans tags: trunk
07:41
Fix [3613759] ttk::entry and symbolic index names. check-in: fcb508e3 user: jan.nijtmans tags: trunk
2013-06-04
13:46
rebase Leaf check-in: f73440d4 user: jan.nijtmans tags: bug-3582795
13:24
Eliminate NO_VIZ macro as current zlib uses HAVE_HIDDEN in stead. One more last-moment fix for FreeBSD by Pietro Cerutti check-in: 61554ab3 user: jan.nijtmans tags: trunk
12:47
Suggested fix for [3613759]: ttk::entry and symbolic index names Closed-Leaf check-in: 4bf2d696 user: jan.nijtmans tags: bug-3613759
2013-06-03
20:28
merge 8.5 check-in: 0705864c user: dgp tags: trunk
2013-05-24
12:29
Disable XInitThreads() call until we have a better test for it. check-in: 76c4cb62 user: jan.nijtmans tags: trunk
2013-05-23
13:31
Extra bit of safety. Since we check whether xinitMutex is "still NULL" to detect a threads-disabled Tcl, we should be explicitly certain it has an initial value of NULL. check-in: 7779a1c4 user: dgp tags: trunk
08:30
Fix for [3613668] by not calling XInitThreads when either 1) Tcl is compiled without threads 2) X11 library is too old. A more direct test would be more desirable, but for now this should be fine. check-in: c98f76a4 user: jan.nijtmans tags: trunk
2013-05-22
07:57
Only call XInitThreads() when we have a very new X11 library. Checked by looking whether XKeycodeToKeysym() is deprecated, which also happend in some very new X11 version. Closed-Leaf check-in: 67d17edf user: jan.nijtmans tags: bug-3613668
2013-05-19
19:47
Fix for FreeBSD, and remove support for old FreeBSD versions. Patch by Pietro Cerutti check-in: 28b0c4de user: jan.nijtmans tags: trunk
2013-04-11
08:40
Tell fossil and Eclipse that the default eol-convention is LF. Tell fossil which files are binary and which files should never be committed. Tell Eclipse that the default encoding is UTF-8 check-in: 864103f6 user: jan.nijtmans tags: trunk
2013-04-10
15:21
[Bug 3568760]: Tk documentation fails to build check-in: edf6d2b7 user: jan.nijtmans tags: trunk
2013-04-08
07:57
Don't work around XkbOpenDisplay's non-const-ness with a macro, when there is only a single call. A type-cast suffices. check-in: ac4aa533 user: jan.nijtmans tags: trunk
2013-04-03
13:54
make dist check-in: 9b73661a user: dgp tags: trunk
13:53
merge-mark check-in: d1122c1d user: dgp tags: trunk
2013-04-01
17:53
silence compiler warning check-in: 43d0360d user: dgp tags: trunk
17:50
3607830 Runtime checks that Xkb is available in the X server before trying to use. Adapted from patch from Brian Griffin. check-in: a2433152 user: dgp tags: trunk
17:14
Bring back test window-2.9. No longer hangs. check-in: 918a5e87 user: dgp tags: trunk
2013-03-29
08:47
merge-mark check-in: 7b36f483 user: jan.nijtmans tags: trunk
2013-03-28
20:52
Demonstrate how the Tk_Main() macro can use Tcl_InitSubsystems(), as fully equivalent replacement of Tcl_FindExecutable/Tcl_CreateInterp. (not part of TIP #414) Closed-Leaf check-in: ff4f5292 user: jan.nijtmans tags: initsubsystems2
15:22
Remove dead code. During 8.6 alpha/beta, Tk_DefineBitmap/Tk_GetBitmapFromData moved to stub entry 274/275 due to a signature change, but later that turned out not be necessary at all. The stub entries were kept in order not to lose binary compatibility for extensions that were compiled against beta 8.6 headers. Now that Tk 8.6 is final, this makes no sense any more. check-in: ce392405 user: jan.nijtmans tags: trunk
08:06
merge-mark check-in: 3261a7f3 user: jan.nijtmans tags: trunk
2013-03-27
14:11
merge-mark check-in: 16ea6a46 user: jan.nijtmans tags: trunk
13:08
merge-mark check-in: e80a1a00 user: jan.nijtmans tags: trunk
11:58
[Bug 3608074]: Add <<Invoke>> bindings to Button's, Listbox and Menu. Document <<Invoke>>, <<ThemeChanged>>, <<EnteredChild>> (ttk_pandedwindow only) and <<Increment/Decrement>> (ttk_spinbox only) check-in: b5f6c04d user: jan.nijtmans tags: trunk
2013-03-22
15:57
merge-mark check-in: fa715a44 user: dgp tags: trunk
15:48
merge mark check-in: a646d74e user: dgp tags: trunk
2013-03-13
15:48
Patch by Andrew Shadura, providing better support for three architectures they have in Debian. check-in: 7477ddea user: jan.nijtmans tags: trunk
2013-03-11
18:39
3607326 Stop segfault from [listbox .l -listvariable $array]. check-in: e8c5b9dd user: dgp tags: trunk
2013-03-08
16:08
Possible (partial) fix for [Bug 3607250] Leaf check-in: ceea1367 user: jan.nijtmans tags: bug-3607250
2013-03-07
21:59
Proposed patch by kjnash. Committed in [1f184c7377] Closed-Leaf check-in: 62653578 user: jan.nijtmans tags: bug-3607248
16:00
Somewhat more benefit from TCL_GLOBAL_ONLY Closed-Leaf check-in: f62f5996 user: jan.nijtmans tags: dgp-review
15:45
Benefit somwhat more from the TCL_EVAL_GLOBAL flag check-in: 7834310f user: jan.nijtmans tags: dgp-review
15:24
Add TCL_EVAL_GLOBAL everywhere, this is actually how it should have been. (Still to be tested on UNIX) check-in: 2169ca59 user: jan.nijtmans tags: dgp-review
14:49
Eliminate all usage of functions Tcl_VarEval (deprecated) and Tcl_Eval (to the prefered Tcl_EvalEx). check-in: 0deef053 user: jan.nijtmans tags: trunk
2013-02-28
09:38
minor: tidy up change log formatting check-in: 3160fe33 user: dkf tags: trunk
09:10
[Bug 3599312]: Apply fix for Alt key problems. check-in: 3972832e user: dkf tags: trunk
2013-02-27
14:41
Revert [ac229dabaa]. There is a reason the Tcl_GetIndexFromObj wrapper exists and is used. check-in: 6c26562f user: jenglish tags: trunk
12:36
Eliminate all Tcl_GetIndexFromObj calls, which is only a thin wrapper around Tcl_GetIndexFromObjStruct. check-in: ac229dab user: jan.nijtmans tags: trunk
2013-02-26
12:18
Remove unneeded SetOptionFromAny and SetTextIndexFromAny. They were only needed to prevent a panic in Tcl, but Tcl now generates a nice error-message in stead of panicing. check-in: b1a5b200 user: jan.nijtmans tags: trunk
2013-02-25
20:33
Put mutex around XInitThreads call, making sure it is only called once. check-in: 557c73ca user: jan.nijtmans tags: trunk
2013-02-22
09:30
Make sure the stubbed variants of Tcl_ObjSetVar2/Tcl_NewStringObj are never used in winMain.c/tkAppInit.c check-in: 34f2a92b user: jan.nijtmans tags: trunk
08:44
Replace all Tcl_TraceVar/Tcl_UntraceVar with Tcl_TraceVar2/Tcl_UntraceVar2 calls: The former are just thin wrappers around the latter. check-in: fd565de1 user: jan.nijtmans tags: trunk
2013-02-18
13:31
Call XInitThreads once before the first Xlib call. Suggested by Brian Griffin. check-in: 2a535c67 user: jan.nijtmans tags: trunk
13:20
Use (preferred) Tcl_ObjSetVar2 in stead of Tcl_SetVar in tkAppInit.c/winMain.c. Remove unneeded use of TEXT() macro, as in tclAppInit.c check-in: 797d8ffe user: jan.nijtmans tags: trunk
2013-02-15
18:45
ttk::theme::* packages don't Provide anything Extra. Change Tcl_PkgProvideEx() back to Tcl_PkgProvide(). check-in: ccdd15ce user: jenglish tags: trunk
16:14
merge-mark check-in: db7d2d30 user: jan.nijtmans tags: trunk
14:37
Eliminate usage of Tcl_PkgProvide/Tcl_PkgRequire functions, use the 'Ex' versions in stead. check-in: 1200c1c2 user: jan.nijtmans tags: trunk
12:44
Eliminate last use of Tcl_GetStringResult check-in: 753122d1 user: jan.nijtmans tags: trunk
2013-02-14
13:55
Add some extra paths on Windows for finding tclConfig.sh, for mSys and Cygwin shell. Improve some comments and quoting, no change in functionality. check-in: c10c3fdb user: jan.nijtmans tags: trunk
2013-02-05
17:44
Restore failing tests to passing. check-in: b2677cc7 user: dgp tags: trunk
2013-02-04
19:50
ttk::treeview: schedule redisplay when adding or removing tags [Bug 3603077]. check-in: 78ab9345 user: jenglish tags: trunk
2013-02-01
16:07
eliminate unnecessary Tcl_ConvertToType call check-in: 1a2f18b1 user: jan.nijtmans tags: trunk
15:49
some more int -> size_t changes check-in: af0c7cac user: jan.nijtmans tags: trunk
14:37
typo check-in: ad17ee85 user: jan.nijtmans tags: trunk
14:30
Use internalRep.twoPtrValue.ptr1 in stead of internalRep.otherValuePtr everywhere. Change some internal "length" variables from type int to type size_t, so it could handle bigger string sizes (for "novem") check-in: dc4fe358 user: jan.nijtmans tags: trunk
2013-01-31
12:41
Merge trunk. Define some macros in tk.h which are needed by Tk as fallback, which might be removed from future tcl.h versions. check-in: 4f65f224 user: jan.nijtmans tags: trunk
11:47
Oops. Missed removing one line in last commit. check-in: 84a425c7 user: stwo tags: trunk
11:41
Bug [3599928]: Use XkbKeycodeToKeysym if available. check-in: addedfa6 user: stwo tags: trunk
11:21
Bug [3602534]: Test for XScreensaver last. check-in: e5a82192 user: stwo tags: trunk
2013-01-28
11:33
merge trunk check-in: 1257e708 user: jan.nijtmans tags: novem-support
11:24
Convert all Tcl_SetResult calls to Tcl_SetObjResult calls. Convert Tcl_GetStringFromObj to Tcl_GetString when possible. check-in: 4c01ee19 user: jan.nijtmans tags: trunk
2013-01-26
00:24
Use some more (void *)'s in FreeProc's, a step in the direction getting Tk to work with "novem" check-in: 9279332c user: jan.nijtmans tags: trunk
2013-01-24
22:23
more places converted check-in: 2d21003b user: jan.nijtmans tags: trunk