Tk Source Code

Timeline
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

22 check-ins related to "bug-1501749fff"

2022-01-31
20:43
Fix [1501749fff] - Crash on embedded window deletion bound to <Map> events. check-in: ee0a9bf9 user: fvogel tags: core-8-6-branch
20:42
Backout temporary commits helping the debug, specifically [33363e00] and [ec5c33bb]. Closed-Leaf check-in: 67436b6b user: fvogel tags: bug-1501749fff
2022-01-30
16:39
Remove debug code inadvertently left in. check-in: d86b7587 user: fvogel tags: bug-1501749fff
16:34
Re-introduce the fix [83d63659], which was correct after more analysis. One cannot make any use of the 'client' pointer after Tk_MaintainGeometry/Tk_MapWindow have been called because they may run event handlers that in turn may destroy the embedded window. In the process the embedded window pointer will be freed and 'client' will point to already freed memory. This analysis was supported by valgrind wich showed the problem with textWind-18.1. check-in: 19d36803 user: fvogel tags: bug-1501749fff
16:09
Fix memory problem revealed by valgrind with textWind-18.2. At this point dInfoPtr is already freed when running textWind-18.2. check-in: 9e98a6d7 user: fvogel tags: bug-1501749fff
2022-01-24
18:08
Ditto for macOS with clang. check-in: ec5c33bb user: fvogel tags: bug-1501749fff
18:07
Temporarily set verbose mode for classic tests on Windows with gcc, to see where exactly it crashes in textWind.test. check-in: 33363e00 user: fvogel tags: bug-1501749fff
2022-01-23
15:13
Fix the first part of [1501749fff]. Now textWind-18.1 passes. check-in: 157d5a2a user: fvogel tags: bug-1501749fff
14:39
Don't use return in DisplayText but 'goto end' so that Tcl_Preserve / Tcl_Release calls keep being balanced. check-in: b8c476ac user: fvogel tags: bug-1501749fff
14:20
More accurate comment. Indeed long ago there used to be Tcl_Preserve/Tcl_Release calls around the call to TkTextPickCurrent but they have been replaced by refcount management when TIP #155 was implemented, see [e58248ce5f8b5af2]. check-in: 5cf0fe4c user: fvogel tags: bug-1501749fff
09:32
Fix the second part of [1501749fff]. Now textWind-18.2 passes. check-in: 511cf9cc user: fvogel tags: bug-1501749fff
09:24
Add some time in textWind-18.1 to make sure it crashes before the test is over. The crash can be seen with TESTFLAGS='-verbose bepst': the log stops with '---- textWind-18.1 start' (i.e. the log shows no end of the test). check-in: f8cfb0b3 user: fvogel tags: bug-1501749fff
09:21
Add (currently crashing) test textWind-18.2 dealing with the issue demonstrated by the second script in comment dated 2022-01-08 23:30:30 in [1501749fff]. This test is constrained with 'knownBug'. check-in: 463699d9 user: fvogel tags: bug-1501749fff
09:07
merge core-8-6-branch check-in: c6c279e3 user: fvogel tags: bug-1501749fff
2022-01-17
22:15
Cherrypick [baf43e83] from trunk. check-in: aa1cff13 user: fvogel tags: core-8-6-branch
2022-01-08
23:25
Backout the wrong fix [83d63659] for [1501749fff], but keep the non-regression testcase marked with 'knownBug' constraint. check-in: 2f86cf37 user: fvogel tags: core-8-6-branch
23:24
Backout the wrong fix [83d63659] for [1501749fff], but keep the non-regression testcase marked with 'knownBug' constraint. check-in: 871384dd user: fvogel tags: bug-1501749fff
23:18
merge core-8-6-branch check-in: 67d5802a user: fvogel tags: bug-1501749fff
20:34
Add "no-xft" tag to tk::build-info check-in: fc5b4a73 user: jan.nijtmans tags: core-8-6-branch
2015-09-29
19:10
Fixed bug [1501749fff] - Crash on embedded window deletion bound to <Map> event check-in: 60ca451d user: fvogel tags: core-8-5-branch
2015-09-23
19:47
Fixed bug [1501749fff] - Crash on embedded window deletion bound to <Map> event check-in: 83d63659 user: fvogel tags: bug-1501749fff
2015-09-13
12:37
Bug [cc0ba31920] - Make text-9.2.46 pass on Windows 8.1 check-in: 62ec64a2 user: fvogel tags: core-8-5-branch