Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
Overview
| Comment: | Fix [ad98f10b3a] and [bd0017bf79] - bitmap-4.1 and cursor-4.1 tests failures. Also, apply again the same pattern to fix color-4.1 that was also failing (when the colorsFree constraint was met) despite there was no such report (yet). Thanks to dgp. |
|---|---|
| Downloads: | Tarball | ZIP archive | SQL archive |
| Timelines: | family | ancestors | descendants | both | trunk |
| Files: | files | file ages | folders |
| SHA1: |
ae13ed6583af621362896bf9b626fa73 |
| User & Date: | fvogel 2016-12-02 20:58:36 |
| Original Comment: | Fix [ad98f10b3a] and [bd0017bf79] - bitmap-4.1 and cursor-4.1 tests failures. Also, apply again the same pattern to fix color-4.1 that was also failing (when the colorsFree constraint was met) despite there was no such report (yet). |
References
|
2018-09-30
| ||
| 10:00 | Fix bitmap-4.1, color-4.1 and cursor-4.1 by cherrypicking the fix [ae13ed65] from trunk. Ticket [ad98f10b3a] dealt with trunk only, the problem appears to be seen in core-8-6-branch as well when running this Tk branch with core-8-branch of Tcl, on Linux Debian 8 at least. check-in: a1a0145c user: fvogel tags: core-8-6-branch | |
|
2016-12-02
| ||
| 21:02 | • Closed ticket [bd0017bf]: New cursor test failure plus 7 other changes artifact: 28dd2de8 user: fvogel | |
| 21:01 | • Closed ticket [ad98f10b]: New bitmap test failure plus 7 other changes artifact: 20f5452b user: fvogel | |
Context
|
2018-09-30
| ||
| 10:00 | Fix bitmap-4.1, color-4.1 and cursor-4.1 by cherrypicking the fix [ae13ed65] from trunk. Ticket [ad98f10b3a] dealt with trunk only, the problem appears to be seen in core-8-6-branch as well when running this Tk branch with core-8-branch of Tcl, on Linux Debian 8 at least. check-in: a1a0145c user: fvogel tags: core-8-6-branch | |
|
2016-12-02
| ||
| 21:05 | Fixed [3ee76e41c2] - New textTag test failures check-in: 074a68b5 user: fvogel tags: trunk | |
| 20:58 | Fix [ad98f10b3a] and [bd0017bf79] - bitmap-4.1 and cursor-4.1 tests failures. Also, apply again the same pattern to fix color-4.1 that was also failing (when the colorsFree constraint was met) despite there was no such report (yet). Thanks to dgp. check-in: ae13ed65 user: fvogel tags: trunk | |
| 12:57 | [76e2d9c095] Repair broken test border-3.1 check-in: ab25b964 user: dgp tags: trunk | |
Changes
Changes to tests/bitmap.test.
| ︙ | ︙ | |||
80 81 82 83 84 85 86 87 |
lappend result [testbitmap questhead]
} -cleanup {
destroy .b1 .b2 .b3 ;# destroying just in case
} -result {{{3 1}} {{2 1}} {{1 1}} {}}
test bitmap-4.1 {FreeBitmapObjProc} -constraints {
testbitmap
} -body {
| > > | | | > | 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 |
lappend result [testbitmap questhead]
} -cleanup {
destroy .b1 .b2 .b3 ;# destroying just in case
} -result {{{3 1}} {{2 1}} {{1 1}} {}}
test bitmap-4.1 {FreeBitmapObjProc} -constraints {
testbitmap
} -setup {
proc copy {s} {return [string index $s 0][string range $s 1 end]}
} -body {
set x [copy questhead]
button .b -bitmap $x
set y [copy questhead]
.b configure -bitmap $y
set z [copy questhead]
.b configure -bitmap $z
set result {}
lappend result [testbitmap questhead]
set x red
lappend result [testbitmap questhead]
set z 32
lappend result [testbitmap questhead]
destroy .b
lappend result [testbitmap questhead]
set y bogus
return $result
} -cleanup {
rename copy {}
destroy .b
} -result {{{1 3}} {{1 2}} {{1 1}} {}}
# cleanup
cleanupTests
return
|
Changes to tests/color.test.
| ︙ | ︙ | |||
251 252 253 254 255 256 257 |
lappend result [testcolor purple]
destroy .t3
lappend result [testcolor purple]
destroy .t
lappend result [testcolor purple]
} {{{4 1} {3 0} {2 0} {1 0}} {{4 1} {2 0} {1 0}} {{4 1} {2 0}} {{2 0}} {}}
| | > > > > | | | > > | | 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 |
lappend result [testcolor purple]
destroy .t3
lappend result [testcolor purple]
destroy .t
lappend result [testcolor purple]
} {{{4 1} {3 0} {2 0} {1 0}} {{4 1} {2 0} {1 0}} {{4 1} {2 0}} {{2 0}} {}}
test color-4.1 {FreeColorObjProc} -constraints {
colorsFree
} -setup {
proc copy {s} {return [string index $s 0][string range $s 1 end]}
} -body {
destroy .b
set x [copy purple]
button .b -foreground $x -text .b1
set y [copy purple]
.b configure -foreground $y
set z [copy purple]
.b configure -foreground $z
set result {}
lappend result [testcolor purple]
set x red
lappend result [testcolor purple]
set z 32
lappend result [testcolor purple]
destroy .b
lappend result [testcolor purple]
set y bogus
set result
} -cleanup {
rename copy {}
} -result {{{1 3}} {{1 2}} {{1 1}} {}}
destroy .t
# cleanup
cleanupTests
return
|
Changes to tests/cursor.test.
| ︙ | ︙ | |||
140 141 142 143 144 145 146 147 |
lappend result [testcursor heart]
destroy .b3
lappend result [testcursor heart]
} -result {{{3 1}} {{2 1}} {{1 1}} {}}
test cursor-4.1 {FreeCursorObjProc} -constraints {
testcursor
} -body {
| > > | | | > | 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 |
lappend result [testcursor heart]
destroy .b3
lappend result [testcursor heart]
} -result {{{3 1}} {{2 1}} {{1 1}} {}}
test cursor-4.1 {FreeCursorObjProc} -constraints {
testcursor
} -setup {
proc copy {s} {return [string index $s 0][string range $s 1 end]}
} -body {
set x [copy heart]
button .b -cursor $x
set y [copy heart]
.b configure -cursor $y
set z [copy heart]
.b configure -cursor $z
set result {}
lappend result [testcursor heart]
set x red
lappend result [testcursor heart]
set z 32
lappend result [testcursor heart]
destroy .b
lappend result [testcursor heart]
set y bogus
set result
} -cleanup {
rename copy {}
destroy .b
} -result {{{1 3}} {{1 2}} {{1 1}} {}}
# -------------------------------------------------------------------------
test cursor-5.1 {assert consistent cursor configuration command} -setup {
button .b
} -body {
|
| ︙ | ︙ |