Tk Source Code

Artifact [9f776f40]
Login

Artifact 9f776f40729fe9b6fc548a7dcb8776957fb7daf310551ea9a55391e5c29c2d64:

Ticket change [9f776f40] - Ticket [1475156f] Numerous select.test failures on macOS status still Open with 6 other changes by fvogel 2018-07-07 11:21:26.
D 2018-07-07T11:21:26.022
J assignee fvogel
J icomment On\smacOS,\sthe\sremaining\sfailing\sselect-*\stests\sare\sselect-3.7,\s4.4,\s5.9,\s5.10,\s9.1,\s9.2,\s9.3,\s9.4,\s9.5,\s10.2,\s10.4,\s10.5,\s10.6,\s11.1,\s12.1,\s12.2,\s12.3,\s12.4,\s12.5,\s13.1\r\n\r\nAll\sthese\stests\sare\scurrently\sconstrained\sto\s"unix"\sbecause\sthey\sexercise\sX\sselection\sownership\schanges\sfrom\sone\sapplication\sto\sanother,\swhich\sin\smy\sunderstanding\sis\sa\sfeature\sspecific\sto\sthis\splatform.\sFor\sthat\spurpose\sthese\stests\smake\suse\sof\sthe\sbackground\sprocess\sprocs\sin\sconstraint.tcl\s(namely\ssetupbg,\scleanupbg...).\r\n\r\nNow,\ssince\sthe\sconstraint\sis\s"unix",\sthese\stests\sare\salso\sexercised\son\smacOS\saqua.\sApparently\sthey\sfail\sbecause\sthe\sexercised\sfeatures\sdo\snot\sexist\son\sthis\splatform\s(they\sneither\sdo\son\sWindows).\sAnother\spossibility\scould\sbe\sthat\sthe\sbg\sprocs\sin\sconstraint.tcl\swould\snot\swork\son\saqua,\showever\sI\sdon't\ssee\swhy\sthis\swould\sbe\sthe\scase.\r\n\r\nMy\sconclusion\sis\stherefore\sthat\sthese\stests\sshould\snot\sbe\sconstrained\sto\s"unix"\sbut\srather\sto\s"x11",\sso\sthat\sthey\swould\sbe\sexercised\son\sX11\splatforms\sonly\s(and\snot\son\sunix\saqua).\r\n\r\nRegarding\sthe\sother\stests\sin\sselect.test\sthat\sare\sconstrained\sby\s"unix":\r\n\r\n\s\s*\sselect-4.6,\s5.13\sand\s5.14\s(skipped\sin\smy\ssetup\sbecause\sof\snon-satisfied\s"altDisplay"\sconstraint)\salso\suse\sthe\sbg\sprocs\sand\sare\sconstrained\sby\s"unix".\sThese\sneeds\srather\sto\sbe\sconstrained\sby\s"x11"\sfor\sthe\sreasons\sstated\sabove.\r\n\r\n\s\s*\sselect-8.1\sdoes\scurently\snot\sfail\son\smacOS\s(constrained\sby\s"unix"\sand\susing\sthe\sbg\sprocs).\sIt\srelies\son\sthe\sreturn\svalue\sof\sthe\sdobg\sprocedure\sto\sbe\san\sempty\sstring.\sAs\sit\sis\swritten,\sit\swill\ssucceed\son\sall\splatforms\seven\sif\sunconstrained.\sHowever,\swhat\swe\sreally\swant\sto\scheck\sis\sthat\swhen\sclaiming\sthe\sCLIPBOARD\sselection\sfrom\sthe\sbg\sproc\s(in\sthe\s.\swindow\sfrom\sanother\sapplication),\sthe\s-command\sscript\sgets\scalled,\sthat\sis\sthe\s.f1\swindow\sgets\sdestroyed\sin\sthe\sinterpreter\sfrom\sthe\stest\sand\sthere\sis\sno\scrash\sbecause\sof\sthis.\sThe\stest\sneeds\sto\scheck\sfor\s"winfo\schildren\s."\sto\sbe\sempty,\sand\sbe\sconstrained\sto\s"x11".\r\n\r\n\s\s*\sselect-10.1\s(constrained\sby\s"unix")\sdoes\snot\sfail\son\smacOS,\sbut\sI\sguess\sit\swould\sif\sit\swas\swritten\sto\suse\sthe\sbg\sprocs.\sIt\sdoes\snot\suse\sthem\sbecause\sof\s[https://core.tcl.tk/tk/info/cda2e66757f87625|a\scomment\sthere\sfrom\sDon\sPorter]\sstating\susing\sthe\sbg\sprocs\sthere\swould\scause\sa\smysterious\sbroken\spipe.\sI'll\sconstraint\sthis\stest\sto\sx11.\r\n\r\n\s\s*\sselect-10.3\s(constrained\sby\s"unix")\sdoes\snot\sfail\son\smacOS\sdespite\sit\suses\sthe\sbg\sprocs.\sThis\sis\sbecause\sit\sexercises\san\serror\scase\sthat\shappens\sto\sbe\sthe\ssame\son\sLinux\sand\smacOS.\sOn\sWindows\sit\swould\sgive\sthe\ssame\serror\sresult,\stherefore\sthis\stest\scould\sbe\sunconstrained.\sFor\sconsistency\showever,\sand\sbecause\sthat\swas\sthe\soriginal\sintent\sI\sthink,\sI'll\sconstrain\sit\sto\sx11.\r\n\r\nI\shave\scommitted\sa\spatch\swith\sall\sthese\schanges,\ssee\s[90f8e7bc9d].
J login fvogel
J mimetype text/x-fossil-wiki
J resolution Fixed
J title Numerous\sselect.test\sfailures\son\smacOS
K 1475156fffffffffffffffffffffffffffffffff
U fvogel
Z ac4be38b8cfcf40daec75ca7fe59e1fe