Tk Source Code

Artifact [11ef4fed]
Login

Artifact 11ef4fed635859ef3dd9f91d42f9a1277368137d:

Ticket change [11ef4fed] - Ticket [d4fb4e80] Image photo commands read/write/put do not accept "-" as first letter in file names resp. image data status still Open with 4 other changes by fvogel 2016-12-07 21:11:36.
D 2016-12-07T21:11:36.027
J assignee fvogel
J icomment Thanks\sfor\sthe\sreport,\spatch\sand\stest\sscripts.\r\n\r\nI\shave\scommitted\syour\spatch\sin\s[http://core.tcl.tk/tk/timeline?r=bug-d4fb4e80d2|branch\sbug-d4fb4e80d2]\sfor\seasy\stesting.\r\n\r\n<TODO>:\sremaining\swork\sto\sdo\sis\sto\stransform\syour\stest\sscripts\sinto\sproper\sTcl\snon-regression\stests.\r\n\r\nAlso,\swith\sthis\spatch\sthe\sfollowing\stest\snow\sfails,\swhich\sis\scertainly\sexpected\ssince\sit\suses\sthe\ssyntax\s"options\sdata"\s(as\sopposed\sto\sdata\sbefore\soptions,\swhich\sis\sthe\sonly\sdocumented\ssyntax\sAFAIK):\r\n\r\n<pre>\r\n====\simgPhoto-4.29\sImgPhotoCmd\sprocedure:\sput\soption\sFAILED\r\n====\sContents\sof\stest\scase:\r\n\r\n\s\s\s\sphoto1\sput\s-to\s10\s10\s20\s20\s{{white}}\r\n\s\s\s\sphoto1\sget\s19\s19\r\n\r\n----\sTest\sgenerated\serror;\sReturn\scode\swas:\s1\r\n----\sReturn\scode\sshould\shave\sbeen\sone\sof:\s0\s2\r\n----\serrorInfo:\scan't\sparse\scolor\s"-to"\r\n\s\s\s\swhile\sexecuting\r\n"photo1\sput\s-to\s10\s10\s20\s20\s{{white}}"\r\n\s\s\s\s("uplevel"\sbody\sline\s2)\r\n\s\s\s\sinvoked\sfrom\swithin\r\n"uplevel\s1\s$script"\r\n----\serrorCode:\sTK\sVALUE\sCOLOR\r\n====\simgPhoto-4.29\sFAILED\r\n</pre>\r\n\r\nChanging\sthis\stest\sby\sswapping\sthe\sorder\sof\sthe\s-to\soption\sand\sthe\sdata\s{{white}}\smakes\sit\spass.\r\n\r\nThe\squestion\shere\sis,\sas\syou\smentioned,\show\smany\sscripts\susing\sthe\swrong\ssyntax\swill\sbe\sbroken\sby\sfixing\sthe\sbug.\sI\ssuggest\sto\sfix\sthis\sonly\sin\strunk\s(i.e.\snot\sin\sthe\s8.6\smaintenance\sreleases).
J login fvogel
J mimetype text/x-fossil-wiki
K d4fb4e80d220e46e588f310291fd7a4205e8cd67
U fvogel
Z 010b99af7bb39dee12236593cc8cc902