Check-in [6982ad54c8]

Login
FlightAware bounty program for improvements to Tcl and certain Tcl packages.

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Add link to alternate implementation for TIP 517
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA3-256:6982ad54c81b731db623d16ddb2a1c30b7f0c7675a2cca4833d917acbb720bfa
User & Date: fvogel 2018-09-12 20:49:10
Context
2018-09-15
09:26
TIP 430 Final; JN merged implementation check-in: 8fe8b2f057 user: dkf tags: trunk
2018-09-12
20:49
Add link to alternate implementation for TIP 517 check-in: 6982ad54c8 user: fvogel tags: trunk
20:43
Add TIP 517 - Add -activerelief Configuration Option to the menu widget check-in: f222243ce8 user: fvogel tags: trunk
Changes

Changes to tip/517.md.

23
24
25
26
27
28
29





30
31
32
33
34
35
36
37
38
39
40
41
42
43
44

It is proposed to add an **-activerelief** configuration option to the menu widget, to make the relief of the active entry configurable. Acceptable values are **raised**, **sunken**, **flat**, **ridge**, **solid**, and **groove**. 

For backwards compatibility reasons, this new option will have its defaults such that the rendering is unchanged compared to the current state of affairs, i.e. it will be **raised** on Linux, and **flat** on other platforms.

This new option will be accepted on all platforms, however on macOS it will be silently ignored since the native menues are used on this platform (***TkpDrawMenuEntry*** is an empty procedure on macOS).






# Alternatives

Alternatively, instead of adding a new **-activerelief** menu option, the issue raised in [bug 43b596451e] (https://core.tcl-lang.org/tk/tktview/43b596451ec6b59359145ff32e689a2eec70bb85) could be resolved by changing the rendering of the active entry in Linux menues to become **TK\_RELIEF\_FLAT**, and keep the current **TK\_RELIEF\_RAISED** only if **tk\_strictMotif** is set. The drawback is that this would constitute a backwards incompatible change - However in turn this could be deemed acceptable in the current alpha state of 8.7.

Having balanced the pros and cons between the two approaches, I'd prefer to add **-activerelief**, which in addition to be a backwards compatible change, has the merit of introducing additional configuration flexibility.

# Implementation

An implementation of this TIP can be found in the [tip-517 branch]
(https://core.tcl.tk/tk/timeline?r=tip-517).

# Copyright

This document has been placed in the public domain.








>
>
>
>
>




|

|
<
<
<





23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41



42
43
44
45
46

It is proposed to add an **-activerelief** configuration option to the menu widget, to make the relief of the active entry configurable. Acceptable values are **raised**, **sunken**, **flat**, **ridge**, **solid**, and **groove**. 

For backwards compatibility reasons, this new option will have its defaults such that the rendering is unchanged compared to the current state of affairs, i.e. it will be **raised** on Linux, and **flat** on other platforms.

This new option will be accepted on all platforms, however on macOS it will be silently ignored since the native menues are used on this platform (***TkpDrawMenuEntry*** is an empty procedure on macOS).

# Implementation

An implementation of this TIP can be found in the [tip-517 branch]
(https://core.tcl.tk/tk/timeline?r=tip-517).

# Alternatives

Alternatively, instead of adding a new **-activerelief** menu option, the issue raised in [bug 43b596451e] (https://core.tcl-lang.org/tk/tktview/43b596451ec6b59359145ff32e689a2eec70bb85) could be resolved by changing the rendering of the active entry in Linux menues to become **TK\_RELIEF\_FLAT**, and keep the current **TK\_RELIEF\_RAISED** only if **tk\_strictMotif** is set. The drawback is that this would constitute a backwards incompatible change - However in turn this could be deemed acceptable in the current alpha state of 8.7.

An implementation for this alternate proposal can be found in [branch tip-517-alt] (https://core.tcl.tk/tk/timeline?r=tip-517-alt).

Having balanced the pros and cons between the two approaches, I'd prefer to add **-activerelief**, which in addition to be a backwards compatible change, has the merit of introducing additional configuration flexibility.




# Copyright

This document has been placed in the public domain.