Artifact [888dab063b]
Not logged in

Artifact 888dab063b39526173afd3255b51b99323b28112:

Ticket change [888dab063b] - Review ticket [ab9ad7b044]: Trying [9c7e118edb] results in http error plus 2 other changes by oehhar 2015-06-02 15:27:48.
D 2015-06-02T15:27:48.510
J +comment \n\n<hr\s/><i>oehhar\sadded\son\s2015-06-02\s15:27:48\sUTC:</i><br\s/>\nProposed\sfix\sin\sbranch\s[bug-ab9ad7b044]\sin\scheckin\s[ea054d339d].\r\n\r\nThe\sissue\sis\sas\sfollows:\r\n\r\n\s\s\s*\s\s\sCheckin\s[411a2eb59f]\smade\sdouble\squotes\saround\sthe\sSOAPAction\sheader.\sThe\sresulting\slist\swas:\s'SOAPAction\s{"ws:action"}'.\r\n\s\s\s*\s\s\sThen,\sthere\sis\sa\smap\sthat\sall\s"{}"\sare\sreplaced\sby\sdouble\squotes,\sresulting\sin\s'SOAPAction\s""ws:action""'.\r\n\s\s\s*\s\s\sThis\sis\snot\sa\slist\sany\smore\swhich\scauses\sthe\shttp\spackage\sto\scomplain.\r\n\r\nThe\sfix\sis\sto\sremove\sthe\smap\scommands:\r\n<verbatim>\r\n-\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s-headers\s[string\smap\s{\\{\s\\"\s\\}\s\\"}\s$headers]\s\\\r\n+\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s-headers\s$headers\s\\\r\n</verbatim>\r\nI\scan\sonly\sguess\sthe\spurpose\sof\sthose.\r\nI\ssuppose\sthey\sare\sjust\swrong.\r\n\r\nThe\sproposed\sfix\salso\sfixes\sa\ssupposed\slist\sissue:\r\n<verbatim>\r\nset\ssvcHeaders\s[dict\sget\s$serviceArr($serviceName)\sheaders]\r\nif\s{[llength\s$svcHeaders]}\s{\r\n-\s\s\s\s\s\s\s\slappend\sheaders\s$svcHeaders\r\n+\s\s\s\s\s\s\s\sset\sheaders\s[concat\s$headers\s$svcHeaders]\r\n}\r\n</verbatim>\r\n\r\nI\swould\sbe\shappy\sfor\sa\sreview.\r\n\r\nHarald
J resolution Fixed
J status Review
K ab9ad7b044f5ac7e2b82e8c7e92ab9d53eba573a
U oehhar
Z 6317e5d25abc2e38e19c7861c25b28db