Tcl Library Source Code

View Ticket
Login
Ticket UUID: a16b1095974e071d294ccbc0cf4671148bddab76
Title: Error in mime.tcl
Type: Bug Version: 1.19
Submitter: plumsli Created on: 2018-07-31 02:51:35
Subsystem: mime Assigned To:
Priority: 5 Medium Severity: Minor
Status: Closed Last Modified: 2021-04-30 14:09:40
Resolution: Fixed Closed By: pooryorick
    Closed on: 2018-08-14 19:41:16
Description:
There is an error on line 674 in mime.tcl:
if {(!$blankP) && ([string last \r $line] == {$x - 1})} {

should be

if {(!$blankP) && ([string last \r $line] == [expr {$x - 1}])} {
User Comments: pooryorick added on 2021-04-30 14:09:40:

Fix merged into trunk in [cb6b4de78f8fe726].


aku added on 2019-06-19 23:45:04:

This fix has never merged to trunk so far. (It was done on branch `pooryorick`, was followed by lots of other changes. I remember then quite a lot of discussion around API (in)compatibility).

The main line fix is commit [b2ae85b606] in response to ticket [57909d2e1c]. Commit here is arguably a nicer fix.

I should have a review of the other mime.tcl changes, see how much can be brought into trunk before running into the parts which got argued about.


pooryorick added on 2018-08-14 19:41:16:

Fixed in [074ec6a961081540].