Overview
Artifact ID: | 41c2b7acc0683277b244aee5d8a0184b2e484660 |
---|---|
Ticket: | e832d2b08fc9e1d1ec9c354806fcdd7e89de6c39
unnecessary code in Tcl_SetMaxBlockTime |
User & Date: | anonymous 2013-10-30 13:06:13 |
Changes
- assignee changed to: "nobody"
- closer changed to: "nobody"
- cmimetype changed to: "text/plain"
- comment changed to:
In generic/tclNotify.c, in the function Tcl_SetMaxBlockTime, checking for tsdPtr->blockTimeSet in the second if-clause is unnecessary. The current code looks as follows: if (!tsdPtr->blockTimeSet || ...) { ... tsdPtr->blockTimeSet = 1; } if (!tsdPtr->inTraversal) { if (tsdPtr->blockTimeSet) { Tcl_SetTimer(&tsdPtr->blockTime); } else { Tcl_SetTimer(NULL); } } Either tsdPtr->blockTimeSet is already 1 when we enter this function, or otherwise the first if-clause will set it to 1. Therefore, the second if-clause can simply read if (!tsdPtr->inTraversal) { Tcl_SetTimer(&tsdPtr->blockTime); }
- foundin changed to: "8.6.0"
- is_private changed to: "0"
- login: "anonymous"
- priority changed to: "5 Medium"
- private_contact changed to: "500c9a7a4e11b3ea0441850610e04006941c0cf3"
- resolution changed to: "None"
- severity changed to: "Minor"
- status changed to: "Open"
- submitter changed to: "anonymous"
- subsystem changed to: "01. Notifier"
- title changed to: "unnecessary code in Tcl_SetMacBlockTime"
- type changed to: "Bug"