Should we add any tests? Should we add any docs? (With these settled, I see no reason to not commit.)