Tcl Source Code

Check-in [df22be24ef]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:3587242 Missing Tcl_MutexUnlock() call made [testasync create] block.
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | core-8-4-branch
Files: files | file ages | folders
SHA1: df22be24ef023bb9c57661258cedef466fd7448c
User & Date: dgp 2012-11-14 22:05:21
Context
2012-11-15
04:16
Remove all the long dead mac/* files (for Mac OS9 !?!). check-in: f9f98900f6 user: dgp tags: core-8-4-branch
2012-11-14
22:07
merge 8.4 check-in: d0b1020ee4 user: dgp tags: core-8-4-20-rc
22:05
3587242 Missing Tcl_MutexUnlock() call made [testasync create] block. check-in: df22be24ef user: dgp tags: core-8-4-branch
16:30
Fix botched patch check-in: 61699305b8 user: dkf tags: core-8-4-branch
Changes
Hide Diffs Unified Diffs Ignore Whitespace Patch

Changes to generic/tclTest.c.

807
808
809
810
811
812
813

814
815
816
817
818
819
820
	asyncPtr->id = nextId;
	nextId++;
	asyncPtr->handler = Tcl_AsyncCreate(AsyncHandlerProc,
		(ClientData) asyncPtr->id);
	asyncPtr->nextPtr = firstHandler;
	firstHandler = asyncPtr;
	TclFormatInt(buf, asyncPtr->id);

	Tcl_SetResult(interp, buf, TCL_VOLATILE);
    } else if (strcmp(argv[1], "delete") == 0) {
	if (argc == 2) {
	    Tcl_MutexLock(&asyncTestMutex);
	    while (firstHandler != NULL) {
		asyncPtr = firstHandler;
		firstHandler = asyncPtr->nextPtr;







>







807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
	asyncPtr->id = nextId;
	nextId++;
	asyncPtr->handler = Tcl_AsyncCreate(AsyncHandlerProc,
		(ClientData) asyncPtr->id);
	asyncPtr->nextPtr = firstHandler;
	firstHandler = asyncPtr;
	TclFormatInt(buf, asyncPtr->id);
	Tcl_MutexUnlock(&asyncTestMutex);
	Tcl_SetResult(interp, buf, TCL_VOLATILE);
    } else if (strcmp(argv[1], "delete") == 0) {
	if (argc == 2) {
	    Tcl_MutexLock(&asyncTestMutex);
	    while (firstHandler != NULL) {
		asyncPtr = firstHandler;
		firstHandler = asyncPtr->nextPtr;