Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
Overview
Comment: | * generic/tclCompCmds.c (TclCompileCatchCmd): Added a more efficient bytecode generator for the case where 'catch' is used without any variable arguments; don't capture the result just to discard it. |
---|---|
Downloads: | Tarball | ZIP archive | SQL archive |
Timelines: | family | ancestors | descendants | both | trunk |
Files: | files | file ages | folders |
SHA1: |
c7bbf4964447e2f65d9b2b0cc4b4d76a |
User & Date: | dkf 2012-01-30 15:43:34 |
Context
2012-01-30
| ||
23:34 | Minor: make comments accurate in [catch] compiler. check-in: b95f569ee3 user: dkf tags: trunk | |
15:43 |
* generic/tclCompCmds.c (TclCompileCatchCmd): Added a more efficient bytecode generator for the ca...check-in: c7bbf49644 user: dkf tags: trunk | |
2012-01-27
| ||
21:56 | 3479689 New internal routine TclJoinPath(). Refactor all the *Join*Path* routines to give them more... check-in: 55c8c6c155 user: dgp tags: trunk | |
Changes
Changes to ChangeLog.
1 2 | 2012-01-26 Don Porter <[email protected]> | > > > > > > | | | | | | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 | 2012-01-30 Donal K. Fellows <[email protected]> * generic/tclCompCmds.c (TclCompileCatchCmd): Added a more efficient bytecode generator for the case where 'catch' is used without any variable arguments; don't capture the result just to discard it. 2012-01-26 Don Porter <[email protected]> * generic/tclCmdAH.c: [Bug 3479689]: New internal routine * generic/tclFCmd.c: TclJoinPath(). Refactor all the * generic/tclFileName.c: *Join*Path* routines to give them more * generic/tclInt.h: useful interfaces that are easier to * generic/tclPathObj.c: manage getting the refcounts right. 2012-01-26 Don Porter <[email protected]> * generic/tclPathObj.c: [Bug 3475569]: Add checks for unshared values before calls demanding them. [Bug 3479689]: Stop memory corruption when shimmering 0-refCount value to "path" type. |
︙ | ︙ |
Changes to generic/tclCompCmds.c.
︙ | ︙ | |||
385 386 387 388 389 390 391 392 393 394 395 396 397 398 | TclEmitOpcode( INST_DUP, envPtr); TclEmitOpcode( INST_EVAL_STK, envPtr); } /* Stack at this point: * nonsimple: script <mark> result * simple: <mark> result */ /* * Emit the "no errors" epilogue: push "0" (TCL_OK) as the catch * result, and jump around the "error case" code. */ PushLiteral(envPtr, "0", 1); | > > > > > > > > > > > > > > > > > > > > > > > > > > | 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 | TclEmitOpcode( INST_DUP, envPtr); TclEmitOpcode( INST_EVAL_STK, envPtr); } /* Stack at this point: * nonsimple: script <mark> result * simple: <mark> result */ if (resultIndex == -1) { /* * Special case when neither result nor options are being saved. In * that case, we can skip quite a bit of the command epilogue; all we * have to do is drop the result and push the return code (and, of * course, finish the catch context). */ TclEmitOpcode( INST_POP, envPtr); PushLiteral(envPtr, "0", 1); TclEmitInstInt1( INST_JUMP1, 3, envPtr); envPtr->currStackDepth = savedStackDepth; ExceptionRangeTarget(envPtr, range, catchOffset); TclEmitOpcode( INST_PUSH_RETURN_CODE, envPtr); ExceptionRangeEnds(envPtr, range); TclEmitOpcode( INST_END_CATCH, envPtr); /* * Stack at this point: * nonsimple: script <mark> returnCode * simple: <mark> returnCode */ goto dropScriptAtEnd; } /* * Emit the "no errors" epilogue: push "0" (TCL_OK) as the catch * result, and jump around the "error case" code. */ PushLiteral(envPtr, "0", 1); |
︙ | ︙ | |||
463 464 465 466 467 468 469 | if (optsIndex != -1) { TclEmitInstInt4( INST_REVERSE, 2, envPtr); Emit14Inst( INST_STORE_SCALAR, optsIndex, envPtr); TclEmitOpcode( INST_POP, envPtr); } | > > | | 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 | if (optsIndex != -1) { TclEmitInstInt4( INST_REVERSE, 2, envPtr); Emit14Inst( INST_STORE_SCALAR, optsIndex, envPtr); TclEmitOpcode( INST_POP, envPtr); } dropScriptAtEnd: /* * Stack is now ?script? result. Get rid of the subst'ed script * if it's hanging arond. */ if (cmdTokenPtr->type != TCL_TOKEN_SIMPLE_WORD) { TclEmitInstInt4( INST_REVERSE, 2, envPtr); TclEmitOpcode( INST_POP, envPtr); |
︙ | ︙ |