Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
Overview
| Comment: | Prevent segfaults attempting to use thread maps after they've been deleted. |
|---|---|
| Downloads: | Tarball | ZIP archive | SQL archive |
| Timelines: | family | ancestors | descendants | both | bug-3397515 |
| Files: | files | file ages | folders |
| SHA1: |
a5b9dc7fa40a5bb4bca83e0445316d2c |
| User & Date: | dgp 2011-08-30 15:44:28 |
Context
|
2011-08-30
| ||
| 16:20 | Prevent leak of interps when using the [testthread exit] command. check-in: 3fc64e5692 user: dgp tags: dgp-thread-leaks | |
| 15:44 | Prevent segfaults attempting to use thread maps after they've been deleted. Closed-Leaf check-in: a5b9dc7fa4 user: dgp tags: bug-3397515 | |
|
2011-08-29
| ||
| 20:41 | Work in progress plugging thread finalization memory leaks. check-in: b34df31421 user: dgp tags: bug-3397515 | |
Changes
Changes to generic/tclIORChan.c.
| ︙ | ︙ | |||
2521 2522 2523 2524 2525 2526 2527 2528 2529 2530 2531 2532 2533 2534 |
/*
* Get the map of all channels handled by the current thread. This is a
* ReflectedChannelMap, but on a per-thread basis, not per-interp. Go
* through the channels and remove all which were handled by this
* interpreter. They have already been marked as dead.
*/
rcmPtr = GetThreadReflectedChannelMap();
for (hPtr = Tcl_FirstHashEntry(&rcmPtr->map, &hSearch);
hPtr != NULL;
hPtr = Tcl_NextHashEntry(&hSearch)) {
chan = Tcl_GetHashValue(hPtr);
rcPtr = Tcl_GetChannelInstanceData(chan);
| > > > | 2521 2522 2523 2524 2525 2526 2527 2528 2529 2530 2531 2532 2533 2534 2535 2536 2537 |
/*
* Get the map of all channels handled by the current thread. This is a
* ReflectedChannelMap, but on a per-thread basis, not per-interp. Go
* through the channels and remove all which were handled by this
* interpreter. They have already been marked as dead.
*/
if (TclInThreadExit()) {
return;
}
rcmPtr = GetThreadReflectedChannelMap();
for (hPtr = Tcl_FirstHashEntry(&rcmPtr->map, &hSearch);
hPtr != NULL;
hPtr = Tcl_NextHashEntry(&hSearch)) {
chan = Tcl_GetHashValue(hPtr);
rcPtr = Tcl_GetChannelInstanceData(chan);
|
| ︙ | ︙ |
Changes to generic/tclIORTrans.c.
| ︙ | ︙ | |||
2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 |
/*
* Get the map of all channels handled by the current thread. This is a
* ReflectedTransformMap, but on a per-thread basis, not per-interp. Go
* through the channels and remove all which were handled by this
* interpreter. They have already been marked as dead.
*/
rtmPtr = GetThreadReflectedTransformMap();
for (hPtr = Tcl_FirstHashEntry(&rtmPtr->map, &hSearch);
hPtr != NULL;
hPtr = Tcl_NextHashEntry(&hSearch)) {
rtPtr = Tcl_GetHashValue(hPtr);
if (rtPtr->interp != interp) {
| > > > | 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212 |
/*
* Get the map of all channels handled by the current thread. This is a
* ReflectedTransformMap, but on a per-thread basis, not per-interp. Go
* through the channels and remove all which were handled by this
* interpreter. They have already been marked as dead.
*/
if (TclInThreadExit()) {
return;
}
rtmPtr = GetThreadReflectedTransformMap();
for (hPtr = Tcl_FirstHashEntry(&rtmPtr->map, &hSearch);
hPtr != NULL;
hPtr = Tcl_NextHashEntry(&hSearch)) {
rtPtr = Tcl_GetHashValue(hPtr);
if (rtPtr->interp != interp) {
|
| ︙ | ︙ |