|
2014-05-02
| ||
| 15:35 | Re-apply [3010352], bringing back the symbol exports of shared libraries as it was in 8.6.0/8.6.1. check-in: 32a6915d8a user: jan.nijtmans tags: trunk | |
| 09:12 | • Add attachment tcloo.patch to ticket [3010352fff] artifact: c342c02df6 user: jan.nijtmans | |
|
2013-08-27
| ||
| 11:24 | • Closed ticket [3010352fff]: make all TclOO API functions MODULE_SCOPE plus 6 other changes artifact: d682c7713d user: jan.nijtmans | |
|
2011-09-28
| ||
| 15:33 | • Ticket [3010352fff]: 6 changes artifact: 8d07b6b974 user: nijtmans | |
| 15:25 | • Ticket [3010352fff]: 4 changes artifact: 13f04d2ed7 user: nijtmans | |
| 15:25 | • Add attachment tcloo.diff to ticket [3010352fff] artifact: 4ea534f8db user: nijtmans | |
| 15:24 | • Ticket [3010352fff] make all TclOO API functions MODULE_SCOPE status still Open with 4 other changes artifact: 46659bb847 user: nijtmans | |
|
2011-09-21
| ||
| 19:16 | • Ticket [3010352fff]: 4 changes artifact: 036761beef user: nijtmans | |
|
2011-03-27
| ||
| 14:09 | • Ticket [3010352fff]: 4 changes artifact: 25dc10af7e user: nijtmans | |
| 14:09 | • Ticket [3010352fff]: 4 changes artifact: 31742541ad user: nijtmans | |
| 14:06 | • Ticket [3010352fff]: 4 changes artifact: d7699203e6 user: nijtmans | |
|
2010-09-20
| ||
| 14:28 | • Ticket [3010352fff]: 4 changes artifact: 833cc65218 user: nijtmans | |
|
2010-09-19
| ||
| 22:41 | • Ticket [3010352fff]: 4 changes artifact: 695d638a20 user: ferrieux | |
|
2010-09-14
| ||
| 04:21 | • Ticket [3010352fff]: 4 changes artifact: 942a730a33 user: nijtmans | |
| 04:20 | • Ticket [3010352fff]: 4 changes artifact: a2735da5e7 user: nijtmans | |
| 04:18 | • Ticket [3010352fff]: 4 changes artifact: 0db606c6df user: nijtmans | |
|
2010-09-13
| ||
| 22:11 | • Ticket [3010352fff]: 5 changes artifact: 5568e0de96 user: nijtmans | |
|
2010-06-02
| ||
| 16:24 | • Ticket [3010352fff]: 4 changes artifact: eecc6c1cea user: nijtmans | |
| 09:24 | • New ticket [3010352fff]. artifact: 44fa9d1604 user: nijtmans | |
| Ticket UUID: | 3010352 | |||
| Title: | make all TclOO API functions MODULE_SCOPE | |||
| Type: | RFE | Version: | None | |
| Submitter: | nijtmans | Created on: | 2010-06-02 09:24:36 | |
| Subsystem: | 35. TclOO Package | Assigned To: | dkf | |
| Priority: | 5 Medium | Severity: | Minor | |
| Status: | Closed | Last Modified: | 2013-08-27 11:24:09 | |
| Resolution: | Fixed | Closed By: | jan.nijtmans | |
| Closed on: | 2013-08-27 11:24:09 | |||
| Description: |
Because dkf (rightfully) only supports accessing those functions through the stub table, there is no need to export them from the dll. dkf wrote in [Tcl Bug #2965424] comments > I also only support it if it is compiled with > stub support; people building statically > are unsupported (and there's certainly no > ABI migration strategy there in any case) So, why not make them all MODULE_SCOPE, then the only way to access them is through the stub table. Here is a patch doing that. The genStubs.tcl modification is taken over from tdbc. It is influenced as well by Joe english (see Patch #941042 remarks), so I guess that Joe and Kevin will be happy as well about this change. | |||
| User Comments: |
nijtmans added on 2011-09-28 15:33:35:
Committed to trunk. Also, here is a new patch for TclOO (8.5 version) doing the same, therefore re-assigning to dkf. nijtmans added on 2011-09-28 15:25:54: File Added - 424696: tcloo.diff nijtmans added on 2011-09-28 15:24:49: File Deleted - 405554: nijtmans added on 2011-09-21 19:16:07: Available now in freq-3010352-impl branch nijtmans added on 2011-03-27 14:09:33: Uploaded new patch against current trunk nijtmans added on 2011-03-27 14:09:08: File Added - 405554: tcloo.patch nijtmans added on 2011-03-27 14:06:28: File Deleted - 386560: nijtmans added on 2010-09-20 14:28:09: >Should it replace it, or is there something more subtle ? The line should be replaced, there is nothing more subtile than that. Thanks!, I'll see if i can create a new patch. ferrieux added on 2010-09-19 22:41:29: Hmm, minor patching issue, the following hunk fails on tclOO.decls, because there's already a line with "
scspec EXTERN". Should it replace it, or is there something more subtle ?
--- generic/tclOO.decls5 Mar 2010 15:32:16 -00001.7
+++ generic/tclOO.decls13 Sep 2010 21:18:11 -0000
@@ -8,6 +8,7 @@
interface tclOO
hooks tclOOInt
+scspec TCLOOAPI
declare 0 generic {
Tcl_Object Tcl_CopyObjectInstance(Tcl_Interp *interp,
nijtmans added on 2010-09-14 04:21:01: re-generated patch against current HEAD nijtmans added on 2010-09-14 04:20:31: File Added - 386560: tcloo.patch nijtmans added on 2010-09-14 04:18:27: File Deleted - 375940: nijtmans added on 2010-09-13 22:11:08: Related to [Bugs #3064962] Suboptimal linkage of stubbed functions. Kevin, how is your opinion on this? nijtmans added on 2010-06-02 16:24:37: File Added - 375940: tcloo.patch | |||