Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
Overview
| Comment: | Stop segfault due to OBOE in CompileWord() calls in [dict lappend] compiler. |
|---|---|
| Downloads: | Tarball | ZIP archive | SQL archive |
| Timelines: | family | ancestors | descendants | both | trunk |
| Files: | files | file ages | folders |
| SHA1: |
166ffc0cc5655a15feed385b9dfd2226 |
| User & Date: | dgp 2013-09-19 04:27:11 |
Context
|
2013-09-19
| ||
| 12:22 | Merge test; bug already fixed in trunk. check-in: dd4cc03df6 user: dgp tags: trunk | |
| 04:27 | Stop segfault due to OBOE in CompileWord() calls in [dict lappend] compiler. check-in: 166ffc0cc5 user: dgp tags: trunk | |
| 04:20 | Stop segfault due to OBOE in CompileWord() calls in [dict lappend] compiler. check-in: 12dfd2bea4 user: dgp tags: core-8-5-branch | |
| 04:11 | [3487626] knownBug tests dict-23.2 and dist-24.21 already fixed on trunk. check-in: d1cc50d7bd user: dgp tags: trunk | |
| 04:03 | [3487626] Backport fix for knownBug test dict-23.2. check-in: b8c8cdb8f4 user: dgp tags: core-8-5-branch | |
Changes
Changes to generic/tclCompCmds.c.
| ︙ | ︙ | |||
1788 1789 1790 1791 1792 1793 1794 |
return TclCompileBasic3ArgCmd(interp, parsePtr, cmdPtr, envPtr);
}
/*
* Issue the implementation.
*/
| | | | 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 |
return TclCompileBasic3ArgCmd(interp, parsePtr, cmdPtr, envPtr);
}
/*
* Issue the implementation.
*/
CompileWord(envPtr, keyTokenPtr, interp, 2);
CompileWord(envPtr, valueTokenPtr, interp, 3);
TclEmitInstInt4( INST_DICT_LAPPEND, dictVarIndex, envPtr);
return TCL_OK;
}
int
TclCompileDictWithCmd(
Tcl_Interp *interp, /* Used for looking up stuff. */
|
| ︙ | ︙ |
Changes to tests/dict.test.
| ︙ | ︙ | |||
1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 |
return [expr {$n - [linenumber]}]
}
}
}
}
}} [linenumber]}}
} 5
rename linenumber {}
test dict-24.22 {dict map results (non-compiled)} {
dict map {k v} [dict map {k v} {a 1 b 2 c 3 d 4} { list $v $k }] {
return -level 0 "$k,$v"
}
} {a {a,1 a} b {b,2 b} c {c,3 c} d {d,4 d}}
test dict-24.23 {dict map results (compiled)} {
| > > > > > > | 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 |
return [expr {$n - [linenumber]}]
}
}
}
}
}} [linenumber]}}
} 5
test dict-23.3 {CompileWord OBOE} {
# segfault when buggy
apply {{} {tcl::dict::lappend foo bar \
[format baz]}}
} {bar baz}
rename linenumber {}
test dict-24.22 {dict map results (non-compiled)} {
dict map {k v} [dict map {k v} {a 1 b 2 c 3 d 4} { list $v $k }] {
return -level 0 "$k,$v"
}
} {a {a,1 a} b {b,2 b} c {c,3 c} d {d,4 d}}
test dict-24.23 {dict map results (compiled)} {
|
| ︙ | ︙ |