Tcl Source Code

Check-in [07438ee67a]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:
* library/http/http.tcl (http::Connect): [Bug 3472316]: Ensure that we only try to read the socket error exactly once.
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | core-8-4-branch
Files: files | file ages | folders
SHA1: 07438ee67a06200baeaffe356b0a0716a5dbcb9c
User & Date: dkf 2012-01-13 11:45:52
Context
2012-01-16
13:29
Ensure that error messages are always set, even in believed-unreachable code. check-in: 97f6b99aed user: dkf tags: core-8-4-branch
2012-01-14
09:30
rfe-3473670: Various Unicode-related speedups/robustness check-in: 92168a99c1 user: jan.nijtmans tags: rfe-3473670
2012-01-13
11:48
* library/http/http.tcl (http::Connect): [Bug 3472316]: Ensure that we only try to read the socket...
check-in: bb0af2dfb6 user: dkf tags: core-8-5-branch
11:45
* library/http/http.tcl (http::Connect): [Bug 3472316]: Ensure that we only try to read the socket...
check-in: 07438ee67a user: dkf tags: core-8-4-branch
2012-01-09
19:59
[Bug 3464428] string is graph \u0120 is wrong check-in: a0c0feafe9 user: jan.nijtmans tags: core-8-4-branch
Changes
Hide Diffs Unified Diffs Ignore Whitespace Patch

Changes to ChangeLog.






1
2
3
4
5
6
7





2012-01-09  Jan Nijtmans  <[email protected]>

	* generic/tclUtf.c:      [Bug 3464428] string is graph \u0120 is wrong
	* generic/regcomp.c:     Remove some unused code
	* generic/regc_locale.c: Add table for Unicode [:cntrl:] class
	* tools/uniClass.tcl:    Generate Unicode [:cntrl:] class table
	* tests/utf.test:
>
>
>
>
>







1
2
3
4
5
6
7
8
9
10
11
12
2012-01-13  Donal K. Fellows  <[email protected]>

	* library/http/http.tcl (http::Connect): [Bug 3472316]: Ensure that we
	only try to read the socket error exactly once.

2012-01-09  Jan Nijtmans  <[email protected]>

	* generic/tclUtf.c:      [Bug 3464428] string is graph \u0120 is wrong
	* generic/regcomp.c:     Remove some unused code
	* generic/regc_locale.c: Add table for Unicode [:cntrl:] class
	* tools/uniClass.tcl:    Generate Unicode [:cntrl:] class table
	* tests/utf.test:

Changes to library/http/http.tcl.

703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
# Side Effects
#	Sets the status of the connection, which unblocks
# 	the waiting geturl call

proc http::Connect {token} {
    variable $token
    upvar 0 $token state
    global errorInfo errorCode
    if {[eof $state(sock)] ||
	[string length [fconfigure $state(sock) -error]]} {
	    Finish $token "connect failed [fconfigure $state(sock) -error]" 1
    } else {
	set state(status) connect
	fileevent $state(sock) writable {}
    }
    return
}








<

|
|







703
704
705
706
707
708
709

710
711
712
713
714
715
716
717
718
719
# Side Effects
#	Sets the status of the connection, which unblocks
# 	the waiting geturl call

proc http::Connect {token} {
    variable $token
    upvar 0 $token state

    if {[eof $state(sock)] ||
	    [string length [set err [fconfigure $state(sock) -error]]]} {
	Finish $token "connect failed $err" 1
    } else {
	set state(status) connect
	fileevent $state(sock) writable {}
    }
    return
}