Artifact
bcfcbb95ee1882cb86d9efcf5dc697fea3768fff:
Ticket change
[bcfcbb95ee]
- Ticket [f4f44174e4]
protect notifier against signals status still Open with 3 other changes
by
aspect
2016-12-06 21:59:19.
D 2016-12-06T21:59:19.587
J icomment You\sare\squite\sright.\s\sThe\sonly\sreason\sthis\sprevented\sthe\shang\sis\sI\sused\sSIG_BLOCK\safter\sreleasing\sthe\smutex\srather\sthan\sSIG_SETMASK.\r\n\r\nthe\spthread_mutex_lock()\scall\sin\sTcl_AlertNotifier()\swas\swhere\sgdb\spointed\swhen\sI\sobserved\sthe\shang,\sbut\sof\scourse\sthis\sis\snot\sthe\splace\sto\sbe\sblocking\ssignals.\r\n\r\nThe\scorrect\splace\sseems\sto\sbe\sTcl_WaitForEvent()\s-\sthe\swrite()\sand\sselect()\scalls\sin\shere\sbeing\sEINTR\scandidates.\s\sIt\slooks\slike\sthe\swrite()\scould\sbe\swrapped\sin\sthe\smoral\sequivalent\sof\swhile\s(errno\s!=\sEINTR)\s-\sand\sselect()\sbeing\sinterrupted\sprobably\swon't\shurt\sanyway\s-\sbut\sblocking\ssignals\sas\slong\sas\swe\shold\sthe\smutex\sseems\sa\sbit\stidier\sto\sme.\r\n\r\nFixed\spatches\sadded\sto\sthe\sbranch.
J login aspect
J mimetype text/plain
K f4f44174e4c88a9132b19bcc4b68346a1d229fe1
U aspect
Z 8fe41005def766e46a2b59ab3bdf6350
