Ticket Hash: | fa152b6a6e511bcede21c61753dd7588b9cfb031 | |||
Title: | pkgindex changes from itk3 to itk4 | |||
Status: | Closed | Type: | Code_Defect | |
Severity: | Important | Priority: | Immediate | |
Subsystem: | Resolution: | Fixed | ||
Last Modified: | 2015-05-01 16:47:39 | |||
Version Found In: | 4.0.1 | |||
User Comments: | ||||
ralfixx added on 2015-04-21 14:31:52:
itk 4 has only lower case package name in pkgindex.tcl, whereas itk3 had only upper case package name. This breaks every script which "package require Itk". For consisteny with itcl and compat with existing scripts, lower- and upper case names should be present in pkgindex.tcl. --- itk4.0.1/pkgIndex.tcl.in~ 2014-10-30 17:07:38.000000000 +0100 +++ itk4.0.1/pkgIndex.tcl.in 2015-04-21 16:30:04.492395479 +0200 @@ -1,3 +1,4 @@ # Tcl package index file, version 1.0 package ifneeded itk @PACKAGE_VERSION@ [list load [file join $dir "@PKG_LIB_FILE@"] itk] +package ifneeded Itk @PACKAGE_VERSION@ [list load [file join $dir "@PKG_LIB_FILE@"] itk] Diff finished. Tue Apr 21 16:30:07 2015 ralfixx added on 2015-04-21 14:40:35: Sorry, incomplete patch. Also required: --- itk4.0.1/generic/itkBase.c~ 2015-03-11 17:59:49.000000000 +0100 +++ itk4.0.1/generic/itkBase.c 2015-04-21 16:36:37.947657221 +0200 @@ -214,6 +214,7 @@ * end-of-the-line? */ + Tcl_PkgProvideEx(interp, "Itk", ITK_PATCH_LEVEL, (ClientData) &itkStubs); return Tcl_PkgProvideEx(interp, "itk", ITK_PATCH_LEVEL, (ClientData) &itkStubs); } Diff finished. Tue Apr 21 16:38:04 2015 dgp added on 2015-05-01 16:47:39: Accepted. |